https://bugzilla.redhat.com/show_bug.cgi?id=1702720
David Lamparter equinox-redhatbugz@diac24.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |equinox-redhatbugz@diac24.n | |et
--- Comment #5 from David Lamparter equinox-redhatbugz@diac24.net --- Hi, upstream maintainer here with feedback.
%global vty_group frrvt
Typo: the group is canonically named "frrvty", note the missing "y". Of course you could rename it but all our docs refer to "frrvty".
(Please don't inherit the historical "quaggavt" - not sure if that was a typo too or some 8-char limit...)
%package devel Summary: Header and object files for frr development
This entire subpackage is useless, FRR does not maintain a stable API or support out-of-tree development of software using libfrr. Just discard the headers and .so/.la files.
%configure \ --sbindir=%{frr_libdir} \ --sysconfdir=%{_sysconfdir}/frr \ --libdir=%{_libdir}/frr \ --libexecdir=%{_libexecdir}/frr \ --localstatedir=%{_localstatedir}/run/frr \ --enable-snmp=agentx \ --enable-multipath=64 \ --enable-vtysh=yes \ --enable-ospfclient=no \ --enable-ospfapi=no \ --enable-user=frr \ --enable-group=frr \ --enable-vty-group=%vty_group \ --enable-rtadv \ --disable-exampledir \ --enable-systemd=yes \ --enable-static=no \ --disable-ldpd \ --disable-babeld \ --enable-sharpd \
sharpd is used for development/testing purposes only and probably shouldn't be packaged.
--with-moduledir=%{_libdir}/frr/modules \ --enable-fpm
install -p -m 644 %{_builddir}/%{name}-%{frrversion}/redhat/daemons %{buildroot}/etc/frr/daemons install -p -m 644 %{_builddir}/%{name}-%{frrversion}/redhat/frr.service %{buildroot}%{_unitdir}/frr.service install -p -m 755 %{_builddir}/%{name}-%{frrversion}/redhat/frr.init %{buildroot}%{frr_libdir}/frr
The redhat/{frr.init,frr.service,daemons} files included in 7.0 are deprecated. Please use tools/{frrinit,frrcommon,watchfrr}.sh, tools/frr.service and tools/etc/frr/daemons instead. (Note this is one of changes in 7.0.1, the old files are gone.)
getent group frrvt >/dev/null 2>&1 || groupadd -r -g %vty_gid frrvt >/dev/null 2>&1 || :
Same typo in group name.
# Create dummy files if they don't exist so basic functions can be used. if [ ! -e %{_sysconfdir}/frr/zebra.conf ]; then echo "hostname `hostname`" > %{_sysconfdir}/frr/zebra.conf chown frr:frr %{_sysconfdir}/frr/zebra.conf chmod 640 %{_sysconfdir}/frr/zebra.conf fi
Split-config (zebra.conf, ospfd.conf) is slowly going the way of the dodo. Please create frr.conf instead.
%files contrib %defattr(-,root,root) %doc COPYING %attr(0644,root,root) tools
Most of the "tools/" content is development tools, not useful to the user. In all honesty, I wouldn't package any of it, except the init scripts & tools/etc bits.
%files devel %defattr(-,root,root) %doc COPYING %dir %{_libdir}/frr/ %{_libdir}/frr/*.so %dir %{_includedir}/frr %{_includedir}/frr/*.h %dir %{_includedir}/frr/ospfd %{_includedir}/frr/ospfd/*.h %dir %{_includedir}/frr/eigrpd %{_includedir}/frr/eigrpd/*.h
As noted above, all of these files could just be discarded. There is no point in a -devel package for FRR.
%changelog
- Wed May 29 2019 Michal Ruprich mruprich@redhat.com - 7.0-1
- Resolves: #1657029 - Add FRR as a replacement of Quagga in RHEL 8
Note 7.0.1 and 7.1 are available upstream.