Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ppl - A modern C++ library providing numerical abstractions
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227669
------- Additional Comments From bagnara@cs.unipr.it 2007-06-12 15:40 EST -------
Well, for 0.9-7:
- %check
- This package contains test/ directory and some check programs seem to be executed. If "make check" makes sense, please add:
%check make check
(Well, this is very very long...)
I guess it is way too long (from a few hours to a full day, depending on the machine): it does a very thorough test of all the library functionalities. I would leave it out for the moment. For PPL 0.10 we may considering having a light `make check' and anchor the current regression-testing facilities to another make target.
- Documentation
- It seems that README.configure is for people who want to rebuild ppl by themselves (i.e. who want to call configure by themselves) and so IMO this document should be removed for rpm user.
This file provides useful documentation for the user. It is needed, for instance, to interpret the output of `ppl-config --configure-options'. Some users may realize that they need to rebuild the PPL by themselves: I estimate the RPM package can cover 95% of the uses, not all of them.
- IMO TODO should be added to documents.
Added.
- %description
- Please refrect static archive split. For example, -devel package says:
%description devel The header files, documentation and static libraries for developing ^^^^^^^^^^^^^^^^^^^^
Fixed.
- rpath issue
- As said above, please let me know if rpath issue is resolved by hacking libtool.
The rpath issue is resolved.
All other things are okay.
Great! Thanks a lot. Here are the revised files:
http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/RedHat/FC6/ppl-0.9-8.sr... http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/RedHat/FC6/ppl.spec http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/ppl-0.9.tar.gz http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/RedHat/FC6/ppl-0.9-docf... http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/RedHat/FC6/ppl-0.9-conf... http://www.cs.unipr.it/ppl/Download/ftp/releases/0.9/RedHat/FC6/ppl-0.9-make...
[I have read comment #37: I will double-check I have understood it properly and come back to you.]