https://bugzilla.redhat.com/show_bug.cgi?id=2141056
--- Comment #2 from Onuralp Sezer thunderbirdtr@gmail.com ---
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file background-mediacenter.svg.license is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License, Version 3", "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* MIT License GNU General Public License, Version 3", "*No copyright* MIT License", "*No copyright* GNU General Public License, Version 3 [generated file]". 51 files have unknown license. Detailed output of licensecheck in /home/astrapel/Pagure/pico- wizard/2141056-pico-wizard/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/pico-wizard [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable, /usr/share/polkit-1, /usr/share/icons/hicolor, /usr/share/polkit-1/rules.d, /usr/share/icons/hicolor/scalable/apps, /etc/pico-wizard [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
pico-wizard.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/PicoWizard/__init__.py 644 /usr/bin/env python3 pico-wizard.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/PicoWizard/__main__.py 644 /usr/bin/env python3 pico-wizard.noarch: W: no-version-in-last-changelog pico-wizard.noarch: W: no-manual-page-for-binary pico-wizard pico-wizard.noarch: W: no-manual-page-for-binary pico-wizard-script-runner pico-wizard.noarch: W: no-manual-page-for-binary pico-wizard-session pico-wizard.noarch: W: no-manual-page-for-binary pico-wizard-wrapper pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/wifi/assets/next.svg /usr/lib/python3.11/site-packages/PicoWizard/PicoWizard/assets/next.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/welcome/assets/next.svg pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/wifi/assets/spinner.svg /usr/lib/python3.11/site-packages/PicoWizard/PicoWizard/assets/spinner.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/finish/assets/spinner.svg pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/assets/background.svg.license /usr/lib/python3.11/site-packages/PicoWizard/assets/background-mediacenter.svg.license pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/mycroft/__init__.py /usr/lib/python3.11/site-packages/PicoWizard/modules/cec/__init__.py pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/wifi/assets/remote-ok.svg /usr/lib/python3.11/site-packages/PicoWizard/modules/cec/assets/remote-ok.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/timezone/assets/remote-ok.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/user/assets/remote-ok.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/welcome/assets/remote-ok.svg pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/utils/__init__.py /usr/lib/python3.11/site-packages/PicoWizard/modules/finish/__init__.py:/usr/lib/python3.11/site-packages/PicoWizard/modules/locale/__init__.py:/usr/lib/python3.11/site-packages/PicoWizard/modules/timezone/__init__.py:/usr/lib/python3.11/site-packages/PicoWizard/modules/user/__init__.py:/usr/lib/python3.11/site-packages/PicoWizard/modules/welcome/__init__.py:/usr/lib/python3.11/site-packages/PicoWizard/modules/wifi/__init__.py pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/welcome/assets/remote.svg /usr/lib/python3.11/site-packages/PicoWizard/modules/finish/assets/remote.svg pico-wizard.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/PicoWizard/modules/wifi/assets/keyboard-ok.svg /usr/lib/python3.11/site-packages/PicoWizard/modules/timezone/assets/keyboard-ok.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/user/assets/keyboard-ok.svg:/usr/lib/python3.11/site-packages/PicoWizard/modules/welcome/assets/keyboard-ok.svg pico-wizard.noarch: W: files-duplicate /usr/share/licenses/pico-wizard/LICENSES/GPL-3.0-or-later.txt /usr/share/licenses/pico-wizard/LICENSE pico-wizard.noarch: E: description-line-too-long Pico Wizard is a setup wizard meant for configuring pre-installed operating systems. 1 packages and 0 specfiles checked; 3 errors, 14 warnings, 3 badness; has taken 0.1 s
Source checksums ---------------- https://invent.kde.org/plasma/pico-wizard/-/archive/934dbcf34e829860a0c79cad... : CHECKSUM(SHA256) this package : d03c2c51c1c53b42cf46b43fb74622089806a83bb2b86ec5f353c47559971c20 CHECKSUM(SHA256) upstream package : d03c2c51c1c53b42cf46b43fb74622089806a83bb2b86ec5f353c47559971c20
Requires -------- pico-wizard (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 /usr/bin/sh NetworkManager config(pico-wizard) kf5-kirigami2 python(abi) python3.11dist(pyside2) python3.11dist(systemd-python) qt5-qtquickcontrols
Provides -------- pico-wizard: config(pico-wizard) pico-wizard python3.11dist(pico-wizard) python3dist(pico-wizard)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2141056 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: C/C++, Ocaml, SugarActivity, R, Haskell, PHP, fonts, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH