https://bugzilla.redhat.com/show_bug.cgi?id=1266804
--- Comment #7 from gil cattaneo puntogil@libero.it --- (In reply to Paulo Andrade from comment #6)
Hi Gil.
Hi Paulo,
Only cut&paste of fedora-review from points I would like some feedback.
[!]: Latest version is packaged. Upstream says latest stable version is 4.2.2. But I see in spec the comment # Newer release require springframework >= 4.1.7.RELEASE
Compatibility problems ... for now we can use this release
[!]: %check is present and all tests pass. I will trust you it is working correctly, from the build log: $ grep "^Tests run: .* Time elapsed.*" /home/pcpa/1266804-springframework-integration/results/build.log Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.206 sec - in org.springframework.integration.router.RouterConcurrencyTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.948 sec - in org.springframework.integration.twitter.config. TestSendingMessageHandlerParserTests Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.config. TestSearchReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec - in org.springframework.integration.twitter.config. TestReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.002 sec - in org.springframework.integration.twitter.ignored.TestSendingDMsUsingNamespace Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.ignored.TestReceivingUsingNamespace Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.001 sec - in org.springframework.integration.twitter.ignored. TestSendingUpdatesUsingNamespace
Seem this tests try to use some unsupported features in our koji build system e.g. (web) connection
[!]: Packages should try to preserve timestamps of original installed files. It is common practive to keep timestamp when converting from dos to unix line ending. For example: sed -i 's/\r//' src/dist/*.txt Should be something like: for file in src/dist/*.txt; do sed -i.orig 's|\r||g' $file touch -r $file.orig $file rm $file.orig done
Done
It took me two tries to understand I should run: $ tar zxf v3.0.7.RELEASE.gz $ sh spring-integration-get-poms.sh 3.0.7.RELEASE to regenerate the poms tarball First I tried using %version :)
Fix comment about poms archive
I consider the package approved. I leave it for you to decide about using the commands to preserve timestamp, because it is indeed changing the file, so, I am fine with either. Just that some reviewers prefer it corrected and some do not care :)
Spec URL: https://gil.fedorapeople.org/springframework-integration.spec SRPM URL: https://gil.fedorapeople.org/springframework-integration-3.0.7-1.fc23.src.rp...
Thanks for your quick review