https://bugzilla.redhat.com/show_bug.cgi?id=1247328
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- if [ $1 ]; then command -v xxd >/dev/null 2>&1 || { echo >&2 "sshrc requires xxd to be installed locally, but it's not. Aborting."; exit 1; } sshrc $@
This is an accident waiting to happen. Proper quoting is required around $@. [ $1 ] will go wrong if options are given on the command line.
xxd is requires but it is not Required by anything.
rm -rf %{buildroot} is not necessary.