[Bug 1360952] Review Request: Quake2 - Client for Quake2 Game ( Yamagi Version)

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360952

--- Comment #12 from Itamar Reis Peixoto  ---
take a look - >

1 - 
Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

2 -

https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...

3 - instead of using cp and mkdir, I think you could use install (man install),
it does Directory creation and file copying in one command, there are a macro
for it called %{__install} , rpm -E '%{__install}'

4  Note: %defattr present but not needed

5 - Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.