https://bugzilla.redhat.com/show_bug.cgi?id=990423
--- Comment #33 from Jose Pedro Oliveira jpo@di.uminho.pt --- (In reply to Ralf Corsepius from comment #32)
(In reply to Christopher Meng from comment #28)
(In reply to Jose Pedro Oliveira from comment #27)
(In reply to Christopher Meng from comment #26)
Fixed.
Spec URL: http://cicku.me/libsodium.spec SRPM URL: http://cicku.me/libsodium-0.4.5-2.fc21.src.rpm
Please add a changelog entry and bump the release.
I'm not prim and propper. It's just a trivial insertion of install -p, not a big change. Why should we waste time here?
To avoid reviewers to look into outdated *.src.rpms containing already fixed issues.
If you want it more formally: This is a MUST
Note I usually bump the version, but I don't want to do this this time. I want to speed up the review.
Hope you can understand.
No, your behavior is unfriendly towards reviewers - You are working sloppy.
I completely agree with Ralf: that's sloppy work. And let me add that reusing the same container file (.src.rpm) to ship different contents is a BLOCKER for me (different content file signatures => bump container NVR).
/jpo