https://bugzilla.redhat.com/show_bug.cgi?id=1980723
--- Comment #7 from Neal Gompa <ngompa13(a)gmail.com> ---
A few questions here:
* Why was the shared library removed? The problem with it is that it needs a
soname configured in CMake so that some kind of API/ABI stability promise
exists. Without the shared library, the headers are not very useful, since
there's nothing to link to.
* Why do we "BuildRequires: systemd"? Generally pulling in systemd itself
isn't
needed.
* Why aren't all the headers namespaced in /usr/include/fluent-bit? Some of
them with rather generic names are in /usr/include instead.
Some other review notes:
* You're not following the guidelines for systemd units
+
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sy...
+
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#packaging
Basically, add "BuildRequires: systemd-rpm-macros", use %{_unitdir} instead of
"%{_prefix}/lib/systemd/system", and add the necessary scriptlets so the
service presets can be used.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1980723