https://bugzilla.redhat.com/show_bug.cgi?id=1872867
--- Comment #9 from Clark Williams williams@redhat.com --- (In reply to Jaroslav Škarvada from comment #6)
Despite the CFLAGS/LDFLAGS problem mentioned in the previous comment, there are few more things:
- Please make consistent use of the spaces and tabs. You used tabs as a
separator for the "Name", "Version" and others tags, but spaces for the "Requires" and "BuildRequires". Please be consistent. This is not a blocker, but nice to have.
I use emacs so that's somewhat transparent to me. I'll go through and re-justify the specfile and hopefully get a more consistent usage.
- I think the systemd configuration file should be installed into the
/etc/sysconfig, i.e. /etc/sysconfig/stalld (without the .conf), not to the /etc/systemd [1]. Also please change the unit file accordingly.
Not sure I agree with this. The config file is strictly for the use of the unit file and I got the impression that the customary place for these paramter files was in /etc/systemd. Let me dig a little deeper here.
- Please use just (this is to also get rid of the unowned
/usr/share/stalld-1.0 directory): %doc README.md to install the README file to the right location (i.e. /usr/share/doc/stalld), the /usr/share/stalld-1.0 seems strange. In such case the README shouldn't be installed in the Makefile. You could also change the Makefile to use the DOCDIR variable and then change the spec: %install %make_install DOCDIR=%{buildroot}%{_docdir}
%files %{_docdir}/README.md
Ok
- Nice to have (not a blocker): consider adding license file to the upstream
project and installing it in the spec by the %license tag, e.g.: %license LICENSE.txt
I added an SPDX tag to the source specifically so we didn't have to carry a licence file. Do you know if there's any effort in Fedora to move the packaging requirements to using SPDX?