https://bugzilla.redhat.com/show_bug.cgi?id=1623764
Pavel Raiskup praiskup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(praiskup@redhat.c | |om) |
--- Comment #2 from Pavel Raiskup praiskup@redhat.com --- Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/praiskup/libpq/libpq.git/pla... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/praiskup/libpq/fedora-rawhid...
Thanks for the your comments!
(In reply to Petr Kubat from comment #1)
libpq obsoletes itself right now as it provides postgresql-libs = 10.5 and obsoletes postresql-libs < 10.6. Are you planning to make the necessary changes to postgresql only after 10.6 releases?
The 10.6 was just development string (I wasn't sure what will be the final Release right before implementing this chagne) -- so correct should be '10.5-4' (at this point in time) because the latest Release shipped in postgresql-libs is '10.5.3'.
Whether the package obsoletes itself..., I'm not sure. I don't think it has such effect in the end. But I bumped the Release to '3' to make sure it's OK.
There is also an issue with directory ownership but I guess that is expected at this point in time. Just something to keep in mind for the changes needed in postgresql.
===== MUST items ===== [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/libpq (postgresql-devel), /usr/share/pgsql(postgresql-server), /usr/include/pgsql(postgresql-devel), /usr/include/pgsql/internal/libpq(postgresql-devel), /usr/include/pgsql/internal(postgresql-devel)
It's not that strict in current Fedora, and directories might co-own files. The list is pretty sane, /usr/include/libpq will be owned only by libpq (same as '/usr/include/pgsql/internal/libpq'), /usr/share/pgsql will be co-owned by (otherwise not coupled in any way) 'libpq-devel' and 'postgresql-server-devel' (ditto for /usr/include/pgsql/internal).
[!]: Package does not generate any conflict. Note: Expected failure as it conflicts with postgresql for now.
Yes, 'postgresql.spec' will be updated atomically with build of libpq.spec and libecpg.spec.
[!]: %check is present and all tests pass.
This requires some work. But libpq.so will be tested extensively by the postgresql.spec builds.