[Bug 210007] Review Request: libtune - standard API to access the kernel tunables

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtune - standard API to access the kernel tunables

https://bugzilla.redhat.com/show_bug.cgi?id=210007

------- Additional Comments From [e-mail]  2007-09-03 02:15 EST -------
> > base_kernel:
> >
> > uname -r would give me something like "2.6.21-1.3194.fc7", while I only need the
> > first 3 fields of it: "2.6.21"
>
> ok, but you don't need the --whatprovides 
> rpm -q --queryformat='%{VERSION}' kernel-headers should be enough
> also buildrequire kernel-headers for this

OK
> > distro_string:
> >
> > I actually only changed it in the tunables-distro-data description.
> > The problem is that anyewhere else, the "FC7" string is used instead of f7. So I
> > would have to change things upstream.
> > But if it is really a problem, please tell me and I'll do the changes, since I
> > am the upstream.
>
> %dist should be fc7 (fedora collection 7) so you should be fine there or did I
> miss anything? btw this is only a cosmetic change.

OK
> The package fails to build here:
>   SYMLINK include/base -> include/basedbs/base-2.6.22.4

This is because 2.6.22 is not supported. Will add support for it and ping when
everything is fixed.