[Bug 1665614] Review Request: libsecp256k1 - Optimized C library for EC operations on curve secp256k1

https://bugzilla.redhat.com/show_bug.cgi?id=1665614

--- Comment #3 from Jonny Heggheim  ---
Thanks for the review. I have updated the files.

(In reply to Robert-André Mauchin from comment #2)
> Please don't use a glob for the major soname version to avoid
>
> unintentional soname bump:
>
> %{_libdir}/%{name}.so.0*

Great, I did not consider that.
> Pre-Release should start at 0.1

I would not classify it as a pre-release, upstream have never released a
version and there are no signs that they are planning a release.

I feel it falls between:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstr...

and

https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snaps...
> Please add the Version-Release info in your %changelog entry:
> Fri Jan 11 2019 Jonny Heggheim  -
>
> 0-0.1.20181126gite34ceb3

Thanks, missed that one.