Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sharutils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226418
------- Additional Comments From bugs.michael@gmx.net 2007-02-06 09:27 EST ------- There is a newer 4.6.3 release plus sig upstream: ftp://ftp.gnu.org/gnu/sharutils/REL-4.6.3/
Prereq: /sbin/install-info
Requires(post): /sbin/install-info Requires(preun): /sbin/install-info
%makeinstall
Standard make install with DESTDIR ought to be preferred, provided that it works:
make DESTDIR=$RPM_BUILD_ROOT install
The %makeinstall macro overrides many Make variables, which can lead to %buildroot finding its way into built files.
mkdir -p ${RPM_BUILD_ROOT}%{_docdir}-%{name}-%{version}
This line should be unnecessary for files installed with %doc.
BuildRoot: ...
Doesn't match the Fedora standard
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
and might be rejected as soon as it might become mandatory.