https://bugzilla.redhat.com/show_bug.cgi?id=1699561
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Group: is not used in Fedora
- Packager: is not used in Fedora
- This should not be used without good reason:
%define debug_package %{nil}
If your package don't generate debug symbols, you need to find why.
- Use %global, not %define
- Make %setup quiet with -q:
%setup -qn reicast-emulator-r%{version}
- Not needed:
rm -rf $RPM_BUILD_ROOT
- Use %set_build_flags to set Fedora default build flags:
%build %set_build_flags
- make %{?_smp_mflags} → %make_build
- make install PREFIX=/usr DESTDIR=$RPM_BUILD_ROOT → %make_install PREFIX=%{_prefix}
- Not needed:
%clean rm -rf %{buildroot}
- Just use
%{_datadir}/%{name}
in %files to own all the files there
- Glob the .gz extension for man pages as the compression might change in the future:
%{_mandir}/man1/reicast.1.* %{_mandir}/man1/reicast-joyconfig.1.*
- Validate the .desktop file in %install or %check:
desktop-file-validate %{buildroot}/%{_datadir}/applications/reicast.desktop
- Remove the env in this too:
sed -i 's//usr/bin/env python//usr/bin/python3/g' shell/linux/tools/reicast-joyconfig.py
- You need to add a %changelog
- Use a better name for your archive:
Source0: https://github.com/reicast/reicast-emulator/archive/r%%7Bversion%7D/%%7Bname...
- Why not add ARM and aarch64 then?
# It can run on ARM and potentially any platform without JIT though. ExclusiveArch: x86_64 %{ix86} %{arm} aarch64