https://bugzilla.redhat.com/show_bug.cgi?id=1665749
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #14 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- This library generates a 'requirements.txt' file for any project → This library generates a 'requirements.txt' file for any Python project
BuildRequires (and other dependencies) should be one-per-line: BuildRequires: %{py3_dist docopt setuptools yarg sphinx} → BuildRequires: %{py3_dist docopt} BuildRequires: %{py3_dist setuptools} ...
+ package name is OK (and subpackages too) + license is acceptable for Fedora (ASL 2) + license is specified correctly + latest version (upstream seems to have tagged 0.4.7 as the latest, but has 0.4.8 in the changelog, and 0.4.9 on pypi.) + builds and installs OK + requires/provides look OK
rpmlint: python3-pipreqs.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python python3-pipreqs.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python python3-pipreqs.noarch: W: spurious-executable-perm /usr/share/man/man1/pipreqs.1.gz
Those are not very important, but correct. Please consider fixing them.
Package is APPROVED.