Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=534135
--- Comment #10 from Michal Ingeli mi@v3.sk 2009-11-30 18:34:43 EDT --- (In reply to comment #9)
@Mical Please assign this bug to you.
I already have.
At least: from my point of view your review is very poor.
It's more "brief". I tried to build package locally, in mock and finally in koji, and it passed. Another important thing is license, and that's also ok.
I gave it another check. There is missing one "must" from java guidelines, and that is "Require: java", jpackage-utils is not enough.
- correctly named - source matches upstream - license in %doc - clean, legible, american english
* I think, javadoc shouldn't be in %doc, but there is not a guideline for that %doc %{_javadocdir}/%{name}-%{version} * add java require (shame, that I missed this one!) * drop epoch from current changelog entry
If you see anything, that is not fulfilling the guidelines, feel free to point it out.