https://bugzilla.redhat.com/show_bug.cgi?id=1223440
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review:
+ mock build is successful for F23 x86_64
- rpmlint on generated rpms gave output nodejs-string_decoder.noarch: W: incoherent-version-in-changelog 0.11.10-0.1.1 ['0.10.31-1.fc23', '0.10.31-1'] nodejs-string_decoder.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
+ License is "MIT" which is valid and included in LICENSE file
+ Source verified with upstream as sha256sum tarball in srpm: 3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086 upstream tarball: 3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086
Suggestions: 1) Group tag is not even needed on EPEL6 so can be removed safely.
2) I have seen missing files in source archive from npm repository. This package also if using source from npm repository you will not get extra files like test cases. Either you can ask upstream to include it in and release new tarball or use github release tarball.
For this package I don't see recent release in 0.10.x series tagged on github. So, good to ask upstream to include test files or else remove test related lines in spec file.
3) Maybe you want to drop following macro as we no longer support < F20 releases. %if 0%{?fedora} >= 19
4) Use %license macro for LICENSE