Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509310
--- Comment #9 from Christian Krause chkr@plauener.de 2009-07-20 18:07:13 EDT --- Before I post the full review, here are some issues I've found so far:
* sources: TODO - please fix Source0 according to the example in the guidelines: http://fedoraproject.org/wiki/Packaging:SourceURL (you should also verify that spectool -g works correctly and retrieves the source file
* subpackage for libgpds: TODO - the naming is not consistent: packagename: libgpds library name: libgpds (incl. SONAME) include path for header files: /usr/include/gpointing-device-settings pkgconfig file: libgpointing-device-settings.pc library flags in the pkgconfig file: -lgpointing-device-settings - at least the last problem must be fixed - otherwise the pkgconfig file can't be used to link anything against this library - preferably also the include path and the pkgconfig file name could be fixed
* BuildRequires: TODO - if there is no specific reason, only gettext (and not gettext-devel) should be a BR
* package owns all directories that it creates: TODO - files are copied into /usr/lib/gnome-settings-daemon-2.0, but it is neither owned by this package nor is the owner of this directory required - I suggest to add: Requires: gnome-settings-daemon
* the corresponding gsynaptics configuration dialog has a menu item in System -> Preferences -> Touchpad - IMHO the same should be done for gpointing-device-settings - please create an appropriate *.desktop file