https://bugzilla.redhat.com/show_bug.cgi?id=1851405
Björn 'besser82' Esser besser82@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |besser82@fedoraproject.org Doc Type|--- |If docs needed, set a value
--- Comment #1 from Björn 'besser82' Esser besser82@fedoraproject.org --- Just a few quick remarks from simply looking at the provided spec file:
Summary: Cryptographic library Name: bee2 Version: 2020.06.24 Release: 1.fc32
*** The release tag MUST use a special macro for the distribution suffix, instead of hardcoding it.
Release: 1%{?dist}
***
License: GPLv3 Url: http://apmi.bsu.by/resources/tools.html Source0: https://notabug.org/kashcheyeu/bee2/archive/master.zip BuildRequires: cmake, gcc
%description Bee2 is a cryptographic library which implements cryptographic algorithm and protocols standardized in Belarus. Additionally, Bee2 implements digital signature algorithms standardized in Russia and Ukraine.
*** The %%description of a MUST wrap lines after ~72 chars.
%description Bee2 is a cryptographic library which implements cryptographic algorithm and protocols standardized in Belarus. Additionally, Bee2 implements digital signature algorithms standardized in Russia and Ukraine.
***
%package devel Summary: Headers for package bee2 Requires: %{name} = %{version}-%{release}
*** The devel package MUST have archful requires, if the devel package is archful itself.
Requires: %{name}%{?_isa} = %{version}-%{release}
***
%description devel Headers for package bee2.
%package static Summary: Static library bee2 %description static Static library bee2.
*** The static package MUST require the devel package.
Requires: %{name}-devel%{?_isa} = %{version}-%{release}
***
#------------------------------------------------------------------
%prep %setup -q -n bee2
*** The %%prep stage SHOULD use %%autosetup, if there is no expilcit reason to prefer %%setup.
%autosetup -n %{name} -p 1
***
%build %cmake
*** It is highly encouraged to run CMake-based builds out-of-tree.
%cmake -S %{_vpath_srcdir} -B %{_vpath_builddir}
The %%build stage MUST run %%make_build, if the package builds binaries.
%make_build -C %{_vpath_builddir}
***
%install %make_install DESTDIR=%{buildroot}
*** Specifying DESTDIR when using the %%make_install macro is NOT NEEDED.
%make_install
***
%check make test
*** Test SHOULD be run in parallel.
%make_build -C %{_vpath_builddir} test
***
%files
/usr/bin/bsum
*** The path to the installed binaries MUST use macros instead hardcoding them.
%{_bindir}/bsum
***
%{_libdir}/libbee2.so %{_libdir}/libbee2_static.a
*** Libraries MUST be shipped in a seperate libs package for enabling multi-arch installation.
The built shared object MUST have a proper so-name, if shipped directly inside of %%{_libdir}.
Static libraries MUST be shipped in a seperate static packge, only. ***
%files static
%{_libdir}/libbee2_static.a
%files devel
/usr/share/bee2/core/b64.h …
*** Header files for libraries MUST be installed under %%{_includedir}. ***
%changelog * Fri Jun 26 2020 Yury Kashcheyeu kashcheyeu@tiksi.ru - 2020.06.24-1 - Initial RPM releas
*** Spelling error: releas --> release ***