Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469291
--- Comment #14 from Christian Krause chkr@plauener.de 2009-02-27 16:04:50 EDT --- Thanks for the review!
(In reply to comment #13)
Please don't do this. Just put that in Version: and use %{version}. It will simplify the spec.
Fixed.
Also, the license tag is wrong. All of the code simply says "GPL", so the tag should be : License: GPL+
Fixed.
Also, it looks like the Source0 url is wrong, it should be: http://user-mode-linux.sourceforge.net/%%7Bname%7D_%%7Bversion%7D.tar.bz2
Fixed, spectool -g SPECS/uml_utilities.spec works fine now, sha1sum: 4e10de8e0f5bf681fa295572009518b77fd8a1dd
And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to BuildRequires it.
Fixed. Package builds fine locally using mock and for F10 and F11:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1206294 https://koji.fedoraproject.org/koji/taskinfo?taskID=1206307
Aside from that, everything looks fine. I'll finish the review, but please show me a finished package before I can flip the approved flag.
I've uploaded the new packages:
Spec URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities-20070815-4.fc10.src.rpm SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities.spec