Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717750
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@uos.de
--- Comment #2 from Martin Gieseking martin.gieseking@uos.de 2011-08-09 15:02:11 EDT --- Hi Yannik,
here are a few quick notes on your spec:
- use %global rather than %define, also see http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_...
- in order to increase legibility, please indent (line up) the text of the header fields (Summary, Name, Version, etc.)
- also list all BuildRequires separately
- You can drop the BuildRoot field. It's still required for EPEL < 6, though. If you want to build the package for the old EPEL distros, you have to add a %clean section and rm -rf $RPM_BUILD_ROOT at the beginning of %install. http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specif...
- Replace LGPL v2.1 with LGPLv2, and GPL v2 with GPLv2. See here for a list of valid license abbreviations: http://fedoraproject.org/wiki/Licensing:Main
- devel packages must require the corresponding base/lib package with a fully versioned dependency: http://fedoraproject.org/wiki/PackagingGuidelines#Requiring_Base_Package
- add a non-empty %description to the devel package
- The %description lines must not exceed 80 chars per line. Just split them appropriately.
- Drop RPM_OPT_FLAGS="$RPM_OPT_FLAGS -fstack-protector-all" from the make statement as it has no effect.
- as the base package seems to provide a GUI application, you must provide a .desktop file and install it properly: http://fedoraproject.org/wiki/PackagingGuidelines#Desktop_files
- replace %defattr(-,root,root) with %defattr(-,root,root,-) or remove it completely. It's still required if you plan to maintain the package for EPEL 4 as well.
- add AUTHORS, ChangeLog, COPYING, and README to the base package (with %doc).