Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ppl-0.9 - A modern C++ library providing numerical abstractions
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227669
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-06-07 03:22 EST ------- (In reply to comment #13)
Some notes:
- Static archive
- Please explain why you want to include static archives in -devel package first. Usually this must not be done for several reasons (maintainance, security, etc) and if you want to ship static archives (with reasonable reason), split all static archives into different subpackages.
The reasons why we need (and routinely use) static libraries are explained in the discussion above. In addition, the PPL can be interfaced to several Prolog engines and some of them require to link the library statically. Concerning the package naming, let me reproduce what I wrote in the discussion above:
Coming back to the C/C++ world, there is the issue of where to put the static libraries. They are now in the ppl-devel package and ppl-pwl-devel packages. Should I move them to
ppl-devel-static and ppl-pwl-devel-static
I prefer this naming style.
- Documentation directory
- should usually be %{_datadir}/doc/%{name}-%{version} ^^^^^^^^^^^^
Including the version would require too many changes (including changing the web pages of the project) and is better postponed to PPL 0.10.
Then I leave it for now.
- and currently /usr/share/doc/ppl/ is not owned by any package.
What can I do to fix that?
Simpy add %dir %{_datadir}/doc/%{name} Also: -------------------------------------------------- %doc %{_datadir}/doc/%{name}/ppl-user-0.9-html/* -------------------------------------------------- (in -docs subpackage) is wrong. In this style, the directory %{_datadir}/doc/ppl-user-0.9-html itself is not owned by any package.
For this case, simply change to -------------------------------------------------- %doc %{_datadir}/doc/%{name}/ppl-user-0.9-html/ -------------------------------------------------- The file entry -------------------------------------------------- foo/ -------------------------------------------------- (where foo/ is a directory) means the directory foo/ itself and all files/directories/etc under foo/
This is a bug in the SWI-Prolog (pl) package: it requires readline-devel. Should we work around that bug and require readline-devel ourselves?
Please do a work-around. I cannot do a formal review unless mockbuild succeeds. Also, if it is a bug of pl side, please file a bug report against pl.