Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584666
--- Comment #2 from Orcan 'oget' Ogetbil oget.fedora@gmail.com 2010-04-27 22:34:51 EDT --- The package is almost ready to go. Here are the results of my review. *'s are blockers:
- rpmlint's complaints about the spelling errors can be ignored, since those are valid technical terms.
! The file README can go to the %doc
* The file plugingui/lv2_ui.h is LGPLv2+, so the license field it the specfile should be "GPLv2+ and LGPLv2+". Please document this in the specfile as a comment.
* Please patch (or sed) the Makefiles so that the build is verbose. The lines where the compilations occur is important.