https://bugzilla.redhat.com/show_bug.cgi?id=2316327
--- Comment #10 from Benson Muite benson_muite@emailplus.org --- Please change License: GPLv2 or BSD to License: (GPL-2.0-or-Later AND BSD-3-Clause) OR (BSD-2-Clause AND BSD-3-Clause) or License: (GPL-2.0-only AND BSD-3-Clause) OR (BSD-2-Clause AND BSD-3-Clause) see https://docs.fedoraproject.org/en-US/legal/spdx/#_spdx_matching_guidelines https://github.com/cornelisnetworks/opa-fm/blob/master/IbAccess/Common/Publi... Check on original sources for iquickmap.c to determine if it is GPL-2.0-only or GPL-2.0-or-later
The main license file seems to just be BSD-3-Clause, perhaps also add a brief explanation of which files are under which license.
Intel Open Source License also seems to be used (please check if it is only for build files, or also for applies to code in shipped binaries): https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-r...
Ideally, each of the licenses would have a license file in the repository, in addition to each file having an indication which license it is under.
Is it possible to For the files listing, you want something like
%license LICENSE %doc README.md %dir %{_sysconfdir}/opa-fm %{_sysconfdir}/opa-fm/dgs %{_sysconfdir}/opa-fm/*.xml %{_sysconfdir}/opa-fm/vfs %dir %{_libdir}/opa-fm %dir %{_libdir}/opa-fm/bin %{_libdir}/opa-fm/bin/config_check %{_libdir}/opa-fm/bin/config_convert %{_libdir}/opa-fm/bin/config_diff %{_libdir}/opa-fm/bin/config_generate %{_libdir}/opa-fm/bin/fm_capture %{_libdir}/opa-fm/bin/fm_cmd %{_libdir}/opa-fm/bin/fm_cmdall %{_libdir}/opa-fm/bin/opafm %{_libdir}/opa-fm/bin/opafmconfigpp %{_libdir}/opa-fm/bin/opafmctrl %{_libdir}/opa-fm/bin/opafmd %{_libdir}/opa-fm/bin/opafmvf %{_libdir}/opa-fm/bin/opafmxmlextract %{_libdir}/opa-fm/bin/opafmxmlfilter %{_libdir}/opa-fm/bin/smpoolsize %dir %{_libdir}/opa-fm/runtime %{_libdir}/opa-fm/runtime/fe %{_libdir}/opa-fm/runtime/sm %dir %{_libdir}/opa-fm/systemd %dir %{_libdir}/opa-fm/systemd/system %{_libdir}/opa-fm/systemd/system/opafm.service %dir %{_libdir}/opa-fm/systemd/system/sbin %{_libdir}/opa-fm/systemd/system/sbinopafmcmd %{_libdir}/opa-fm/systemd/system/sbin/opafmcmdall %{_libdir}/opa-fm/systemd/system/sbin/opafmconfigpp %{_libdir}/opa-fm/systemd/system/sbin/opafmvf %dir %{_docdir}/opa-fm %{_mandir}/man8/opafmcmd.* %{_mandir}/man8/opafmcmdall.* %{_mandir}/man8/opafmconfigpp.* %dir %{_datadir}/opa-fm %{_datadir}/opa-fm/*.xml %dir %{_datadir}/opa-fm/samples %{_datadir}/opa-fm/samples/*.cnf-sample
Binary files and libraries should be explicitly listed, though and configuration files can be globbed
The install script hard copies using lib, and it would be better to use lib64 on 64bit architectures: https://github.com/cornelisnetworks/opa-fm/blob/master/Esm/fm_install.sh#L43 Created a pull request to fix this: https://github.com/cornelisnetworks/opa-fm/pull/33