https://bugzilla.redhat.com/show_bug.cgi?id=1771173
--- Comment #2 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- (In reply to leigh scott from comment #1)
Change this from
BuildRequires: cmake >= 3.10
to
BuildRequires: cmake3 >= 3.10
and this
%build %cmake %make_build
to
%build %cmake3 %make_build
Done
You also need to validate the appdata file
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ #_app_data_validate_usage
Good catch. Appdata is included upstream and validation is applied.
Also change the source url from
URL: https://github.com/%%7Bname%7D/%%7Bname%7D Source0: https://github.com/%%7Bname%7D/%%7Bname%7D/archive/%%7Bversion%7D.tar.gz#/%%... %{version}.tar.gz
to
URL: https://github.com/xournalpp/xournalpp Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz
It makes it easier to read and navigate to the url
Given the name of the project and its team are identical, I keep the %{name} for URL path and use %{url} for the Source0.
Also there is no need to use %{name}-%{version} in setup, change
%prep %autosetup -n %{name}-%{version}
to
%prep %autosetup
Done.
Here is the updated SPEC: https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhid... SPRMS: https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhid...