https://bugzilla.redhat.com/show_bug.cgi?id=2241780
--- Comment #4 from blinxen h-k-81@hotmail.com --- Here is my initial review:
* Please change the license to a valid SPDX identifier. In this case it should be `GPL-3.0-only`. * According to https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_packag..., you must add `gcc`, `gcc-c++` or `clang` to `BuildRequires`. * Please remove "(Unretirement review)" from the bug description. * The description includes a link to http://masterpasswordapp.com, which redirects to https://spectre.app/. Please update the description. * According to https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data... the appdata.xml file should be located in "%{buildroot}%{_metainfodir}/". * Not really an issue, but the marco `commit` should probably be renamed to git_tag or tag as it essentially a git tag and not a commit hash. * Also not an issue, but I would change $RPM_BUILD_ROOT to %{buildroot}.