Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674008
Tim Niemueller tim@niemueller.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|Package Review |0xFFFF Flag|fedora-review? |
--- Comment #65 from Tim Niemueller tim@niemueller.de 2011-12-13 06:54:53 EST --- Peter, thanks for the review. Finally I got around to package OpenRAVE 0.5.0 and fix the problems you mentioned: - dos2unix on some files - no more zero-length octave files (fixed upstream) - did not fix the non-executable-script warnings, they should be fixed upstream - devel sub-package depends on cmake
I have also updated the patch, Rosen please re-check if this is suitable to include upstream, it does: - provide compatibility with older Boost versions (think of Enterprise Linux) - Make include directory name a variable that can be overridden (for example to use only a major version suffix at some point) - Allow overriding of share directory (not using version suffix on Fedora, but default to use it - Allow overriding of library suffix (no version suffix on Fedora) - Allow overriding of CMake directory name (default to the original value, set on Fedora from cmake call) - Allow overriding of CPack package install directory - pkg-config file uses the new variables
The new SRPM is at http://fedorapeople.org/~timn/robotics/openrave-0.5.0-1.fc15.src.rpm, spec file changed in place.