https://bugzilla.redhat.com/show_bug.cgi?id=2251086
--- Comment #6 from Tom Rix trix@redhat.com --- For Ben's question about %check Checking depends on having an AMD GPU in the build machine, that is not possible. The -test subpackage is consistent with how other rocm packages have handled this. However in the other packages -test is off by default and not expected to be part of the offical fedora release. We should be consistent, can rocfft also have -test off by default ?
New comments CMAKE_BUILD_TYPE=Debug We have not figured out how or if to do this. I know from my own experiments that this will cause packing errors when the rpm tooling does not handle some clang-ism. And if we did have a -debug, I would not want to *-d.so lib names.
Above, I also changed the RELEASE to RelWithDebInfo so it would be consistent with other packages.
The explicit list of AMDGPU_TARGETS is missing some, you can see in the cmake output that gfx94x is checked. If we need a full list, I think it would be useful to add that to rocm-rpm-macros package macros.rocm file.