Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: vorbisgain - Adds tags to Ogg Vorbis files to adjust the volume
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191592
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From bdpepple@ameritech.net 2006-05-13 13:46 EST ------- MD5Sums: ee62352b74c610bb3eeddda038819fc8 vorbisgain-0.34.zip
Good: * Source URL is canonical * Upstream source tarball verified * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * rpmlint produces no errors * Package installs and uninstalls cleanly on FC5 * Software runs fine
Minor: * License is LGPL, not GPL. * Inconsistant use of '$RPM_BUILD_ROOT' & '%buildroot'. Use only one or the other.
These two items can be corrected after you import them into FE CVS
+1 APPROVE
I'll also be your sponser. If you haven't created an account yet, you will need to do so.
http://fedoraproject.org/wiki/Extras/Contributors#head-a89c07b5b8abe7748b6b3...