[Bug 530204] Review Request: rubygem-hawler - Hawler, the Ruby HTTP crawler

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=530204

--- Comment #2 from Jeroen van Meeuwen   2009-10-24 19:03:12 EDT ---
(In reply to comment #1)
> Some notes
> Unneeded macro
> %ruby_sitelib is used nowhere.

Removed
> License
> MIT.
> However please include the following file
> http://spoofed.org/files/hawler/src/COPYING
> in the srpm with the full URL and install this
> file (I think installing under %geminstdir is
> better), mark this as %doc

Fixed
> %description
> Are there any a bit more detailed description?

I c/p'ed an extra line from the README, not sure what else to put in there.
> Test
> As this gem file contains test/ directory, please
> add %check section and execute some tests there.

Two out of three tests require rubygem-hpricot, which is not in Fedora yet.
Enabled the other test though.

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec
New SRPM:
http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-3.fc12.src.rpm