Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=588941
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #48 from Kevin Fenzi kevin@tummy.com 2011-01-02 14:33:41 EST --- Wow. This is much nicer now. ;)
I really appreciate all the comments in the spec explaining how things are done/why they are done.
All the issues from my initial review seem fixed. The source matches up from upstream. We can ignore the 2 rpmlint issues that are left.
I'm not seeing any further blockers here, so this package is APPROVED.
I'm sure you'll work on fixing tests and improving things over time as time permits. ;)