https://bugzilla.redhat.com/show_bug.cgi?id=1185662
Pranav Kant pranav913@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pranav913@gmail.com
--- Comment #1 from Pranav Kant pranav913@gmail.com --- This is an unofficial review.
Skimming through the spec file and a quick review made me point out following problems. Please have a look at points below.
- You should either macro style (%{buildroot}) or variable style ($RPM_BUILD_ROOT) consistently throughout the spec file. Mixing both of these is bad from usability point of view. Please use one style throughout the spec file.
See : http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_...
- defattr is not needed for rpm >=4.4. See : http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- rpmlint output :
Checking: shadowd-1.0.0-1.fc21.x86_64.rpm shadowd-1.0.0-1.fc21.src.rpm shadowd.x86_64: E: explicit-lib-dependency libdbi-dbd-mysql shadowd.x86_64: E: explicit-lib-dependency libdbi-dbd-pgsql shadowd.x86_64: W: spelling-error %description -l en_US expandability -> expand ability, expand-ability, dependability shadowd.x86_64: W: non-standard-gid /etc/shadowd/shadowd.ini shadowd shadowd.x86_64: E: non-readable /etc/shadowd/shadowd.ini 0640L shadowd.src: W: spelling-error %description -l en_US expandability -> expand ability, expand-ability, dependability shadowd.src: W: strange-permission shadowd.spec 0666L shadowd.src: W: strange-permission shadowd.service 0666L shadowd.src: W: strange-permission shadowd-1.0.0.tar.gz 0666L 2 packages and 0 specfiles checked; 3 errors, 6 warnings.