Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gpsman - GPS data manager
https://bugzilla.redhat.com/show_bug.cgi?id=435042
kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kanarip@kanarip.com 2008-02-28 16:53 EST ------- RPM Lint: OK Package name: OK Spec file: OK (suggest you make use of %{name} and %{version} in the Source0 URL) License: OK Actual License: OK (GPLv2+) %doc License: OK Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK Compile and Build: - F-7: OK - F-8: OK - rawhide: OK - EL-5: OK
Applicable Package Guidelines: OK Locales: N/A Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK (suggest use %{name} and %{version} in Source0) Code vs. Content: OK (Large) Documentation: OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: N/A Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK
Pretty straightforward, APPROVED