https://bugzilla.redhat.com/show_bug.cgi?id=1714377
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #2 from Miro Hrončok mhroncok@redhat.com --- I can sponsor you.
Let's finish this review first and later I'll need you to do some reviews for others, if that's OK.
=====
Early feedback:
Spec looks simple and sane.
-----
Please, add a %check section with tests:
https://github.com/ansible-community/ansible-bender/tree/master/tests
-----
As a matter of style (totally feel free to ignore this):
1) when requires are one package per line, they tend to be better managed in git than putting them all in one line
2) the package already requires this by RPM mechanisms:
/usr/bin/python3 python(abi) = 3.7 python3.7dist(jsonschema) python3.7dist(pyyaml) python3.7dist(tabulate)
=> there is no need to require python3 manually (and while harmless in Fedora, such require could break for example in RHEL 8 if building for other Python version).