Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=735160
--- Comment #8 from Stephen Gallagher sgallagh@redhat.com 2012-04-25 19:55:00 EDT --- (In reply to comment #7)
Some few notes/questions:
- I'd remove bundled egg-info in prep-section. You should move that form
install to prep-section.
It took me a while to realize what you meant. I've now removed the version of the .egg-info that shipped with the tarball so that it is regenerated by setup.py. It is now shipping in %files again, but rebuilt properly.
- You have left rm -rf $RPM_BUILD_ROOT in install section, clean section is not
needed anymore.
That section was created automatically by rpmdev-newspec. I've removed it. I'm unclear about what you meant about the install section though. Should I remove the rm -rf there as well?
- you even don't need the %defattr(-,root,root,-)-line in files-section.
Removed.
New spec: http://sgallagh.fedorapeople.org/packagereview/django-socialregistration/pyt...
New SRPM: http://sgallagh.fedorapeople.org/packagereview/django-socialregistration/pyt...
Koji scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4023330