https://bugzilla.redhat.com/show_bug.cgi?id=2141068
--- Comment #2 from Kalev Lember klember@redhat.com --- (In reply to Fabio Valentini from comment #1)
Taking this review.
Initial comments:
- Please don't ignore big FIXMEs in specs generated by rust2rpm.
In this case, Apache-2.0 license file is missing. Please report this upstream.
Done: https://github.com/frehberg/test-generator/issues/15
- The summary is way too long, please trim it to something sensible like
"Generate test functions for all files matching a pattern" or something like that (or you can come up with something better - the current description is kind of confusing and I don't really understand what it's trying to say).
Thanks, I've updated the spec file to use your suggestion. I don't think it really matters much as the Fedora packaging is just for use in koji and I imagine everybody else is just getting the crates from crates.io directly.
I wonder if maybe we should update rust2rpm to generate a shorter summary and leave the upstream text for description? Like,
Summary: rust "%{crate}" crate %global _description %{expand: Rust Test generator: enumerating entries according to file-system pattern and generating a test function for each entry.}
%description %{_description}
Something like this would allow for a bit more automation :)