https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Bug ID: 2161337 Summary: Review Request: python-types-python-dateutil - Typing stubs for dateutil Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-type... SRPM URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-type...
Description: This is a PEP 561 type stub package for the python-dateutil package. It can be used by type-checking tools like mypy, PyCharm, pytype etc. to check code that uses python-dateutil. The source for this package can be found at https://github.com/python/typeshed/tree/main/stubs/python-dateutil. All fixes for types and metadata should be contributed there.
See https://github.com/python/typeshed/blob/main/README.md for more details. This package was generated from typeshed commit bff43b53e50adf873c20faebb125a5fe808d4ad6.
Fedora Account System Username: ankursinha
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #1 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=96210656
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5238133 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Trivial Doc Type|--- |If docs needed, set a value Blocks| |1276941 (fedora-neuro)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Is this a runtime dependency or a BuildRequires for testing? If it’s the latter, you might be better patching out the typechecker from the tests (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters).
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #4 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Ah, right. This one is BR for testing datalad locally. I'll take a look at patching it out first.
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- I’m happy to review it if it’s not just for mypy. There are a few Python libraries that use type information at runtime, although I bet this isn’t one of those cases.
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Neil Hanlon neil@shrug.pw changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |neil@shrug.pw Assignee|nobody@fedoraproject.org |neil@shrug.pw
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #6 from Neil Hanlon neil@shrug.pw --- oops. I apologize, i didn't read the whole discussion before taking. Still happy to take this as my first review if it is necessary.
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Flags|fedora-review? | Status|ASSIGNED |CLOSED Last Closed| |2023-02-28 11:26:20
--- Comment #7 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Sorry for the delay folks. This is indeed only a linting dep, so we won't package it.
Neil, sorry about that. I have a couple of other reviews pending if you'd like to take them up:
https://bugzilla.redhat.com/show_bug.cgi?id=2173665 https://bugzilla.redhat.com/show_bug.cgi?id=2166009
https://bugzilla.redhat.com/show_bug.cgi?id=2161337
--- Comment #8 from Neil Hanlon neil@shrug.pw --- (In reply to Ankur Sinha (FranciscoD) from comment #7)
Sorry for the delay folks. This is indeed only a linting dep, so we won't package it.
Neil, sorry about that. I have a couple of other reviews pending if you'd like to take them up:
https://bugzilla.redhat.com/show_bug.cgi?id=2173665 https://bugzilla.redhat.com/show_bug.cgi?id=2166009
Not a problem. I will take a look and see if I might be able to take one of them on with my current workload.
Thank you!
package-review@lists.fedoraproject.org