Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: debhelper - Helper programs for debian/rules
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Summary: Review Request: debhelper - Helper programs for debian/rules Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kanarip@kanarip.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://git.ergo-project.org/?p=kolab-fedora.git;a=blob_plain;f=f12/custom-f1... SRPM URL: http://koji.ergo-project.org/packages/debhelper/7.0.15/1.fc12.buildsys/src/d... Description:
A collection of programs that can be used in a debian/rules file to automate common tasks related to building debian packages. Programs are included to install various files into your package, compress files, fix file permissions, integrate your package with the debian menu system, debconf, doc-base, etc. Most debian packages use debhelper as part of their build process.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |591192
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |591388
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #1 from Chen Lei supercyper1@gmail.com 2010-05-12 04:48:50 EDT ---
1.There are some documention in doc/, please also include them %doc
2.URL should be http://kitenet.net/~joey/code/debhelper/
3.RPM cannot pick up all dependencies automatically, you may need at least add some of the depends listed in http://packages.debian.org/en/sid/debhelper
4.Please also intall manpage for locale fr and es.
5.Considering update rpm to the latest version(7.4.19)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #2 from Jeroen van Meeuwen kanarip@kanarip.com 2010-05-14 14:25:29 EDT --- (In reply to comment #1)
1.There are some documention in doc/, please also include them %doc
Included.
2.URL should be http://kitenet.net/~joey/code/debhelper/
URL Changed.
3.RPM cannot pick up all dependencies automatically, you may need at least add some of the depends listed in http://packages.debian.org/en/sid/debhelper
Added the dependencies
4.Please also intall manpage for locale fr and es.
Done.
5.Considering update rpm to the latest version(7.4.19)
Done.
New SPEC: http://git.ergo-project.org/?p=kolab-fedora.git;a=blob;f=f12/custom-f12-buil... New SRPM: http://koji.ergo-project.org/packages/debhelper/7.4.20/2.fc12.buildsys/src/d...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |supercyper1@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #3 from Chen Lei supercyper1@gmail.com 2010-05-30 05:29:52 EDT --- rpmlint debhelper-7.4.20-2.fc12.buildsys.src.rpm debhelper.src: W: spelling-error Summary(en_US) debian -> Debian debhelper.src: W: spelling-error %description -l en_US debian -> Debian debhelper.src: W: spelling-error %description -l en_US debconf -> debonair, deacon, debouch debhelper.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
The last warning should be fixed.
Some other comments about spec:
Requires: man is not needed.
%doc examples/ doc/ could be changed to %doc examples/ doc/*.
BuildRequires: dpkg-devel seems not needed, also po4a is not available in fedora.
For man page, lang(locale) should add before %{_mandir}/locale/ or use gettext (%find_lang --with-man)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de
--- Comment #4 from Ralf Corsepius rc040203@freenet.de 2010-05-30 06:14:52 EDT --- (In reply to comment #3)
also po4a is not available in fedora.
Wrong, po4a is available in Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Oron Peled oron@actcom.co.il changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |oron@actcom.co.il
--- Comment #5 from Oron Peled oron@actcom.co.il 2010-10-11 20:00:19 EDT --- Fixed comment 3:
debhelper.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
11) Done
Requires: man is not needed.
Removed
%doc examples/ doc/ could be changed to %doc examples/ doc/*.
Done
BuildRequires: dpkg-devel seems not needed,
Removed (Also Debian does not list dpkg-dev as BR of debhelper)
also po4a is not available in fedora.
po4a is in Fedora (comment 4), so it was added as a BuildRequires.
For man page, lang(locale) should add before %{_mandir}/locale/ or use gettext (%find_lang --with-man)
Done.
SPEC URL: http://oron.fedorapeople.org/deb-package/debhelper.spec SRPM URL: http://oron.fedorapeople.org/deb-package/debhelper-8.0.0-1.fc13.src.rpm
rpmlint output:
$ rpmlint ./debhelper.spec /usr/local/src/rpmbuilder/rpmbuild/SRPMS/debhelper-8.0.0-1.fc13.src.rpm /usr/local/src/rpmbuilder/rpmbuild/RPMS/noarch/debhelper-8.0.0-1.fc13.noarch.rpm debhelper.src: W: spelling-error %description -l en_US debconf -> deb conf, deb-conf, debonair debhelper.noarch: E: devel-dependency dpkg-devel debhelper.noarch: W: spelling-error %description -l en_US debconf -> deb conf, deb-conf, debonair debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.multi2 debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.multi debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.arch debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.indep debhelper.noarch: W: spurious-executable-perm /usr/share/doc/debhelper-8.0.0/examples/rules.tiny debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.multi2 /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.multi /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.arch /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.indep /usr/bin/make debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-8.0.0/examples/rules.tiny /usr/bin/make 2 packages and 1 specfiles checked; 1 errors, 12 warnings.
Notes: * The examples/ directory contain "debian/rules" files which are, by definition executable "scripts" run by /usr/bin/make [10 out of 12 rpmlint warnings] * rpmlint spell warning about "debconf" [2 out of 12 rpm warnings, one from SRPM, another from RPM] * Dependency devel rpmlint error is unjustified, since debhelper is a devel package itself.
My fixes are meant to help unblock bug 591192 and eventually, bug 591388. I am willing to co-maintain these packages if needed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #6 from Oron Peled oron@actcom.co.il 2010-10-11 20:04:10 EDT --- Forgot to mention in comment 5: bumped version to 8.0.0 to match Squeeze version.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #7 from Ralf Corsepius rc040203@freenet.de 2010-10-12 01:48:04 EDT --- (In reply to comment #5)
Fixed comment 3:
BuildRequires: dpkg-devel seems not needed,
Removed (Also Debian does not list dpkg-dev as BR of debhelper)
BR: dpkg-devel is required to pull-in dpkg-parsechangelog
Without it, your package doesn't build correctly: ... + make build /bin/sh: dpkg-parsechangelog: command not found printf "package Debian::Debhelper::Dh_Version;\n$version='';\n1" > \ Debian/Debhelper/Dh_Version.pm /bin/sh: dpkg-parsechangelog: command not found cat debhelper.pod | \ perl -e ' undef $/; foreach (@ARGV) { open (IN, $_) or die "$_: $!"; $file=<IN>; close IN; if ($file=~m/=head1 .*?\n\n(.*?) - (.*?)\n\n/s) { my $item="=item $1(1)\n\n$2\n\n"; if ($2!~/deprecated/) { $list.=$item; } else { $list_deprecated.=$item; } } } END { while (<STDIN>) { s/#LIST#/$list/; s/#LIST_DEPRECATED#/$list_deprecated/; print; }; }' `find . -maxdepth 1 -type f -perm +100 -name "dh_*" | sort` | \ pod2man -c Debhelper -r "" --name="debhelper" --section=7 > debhelper.7 /bin/sh: dpkg-parsechangelog: command not found /bin/sh: dpkg-parsechangelog: command not found /bin/sh: dpkg-parsechangelog: command not found ..
It also fails to exercise its testsuite: make test ... t/buildsystems/buildsystem_tests .. 1/300 Can't exec "dpkg-architecture"
- The examples/ directory contain "debian/rules" files which are, by definition executable "scripts" run by /usr/bin/make [10 out of 12 rpmlint warnings]
Please chmod -x them.
Inside of the Fedora package, these are meant to be mere informative documentation and not supposed to be executable/to be run by anybody.
Furthermore:
* The package comes with a testsuite. Please add a %check section to your spec executing "make test".
Doing so, triggers a couple of errors. AFAIS, some of them seem to be originating from perl-5.10/5.12 incompatibilities in Fedora's dpkg (Could be an indication of Fedora's dpkg packages to be outdated or broken) or of Fedora's dpkg to be incompatibile to this debhelper package (I haven't investigated in depth).
* Consider (Not a blocker) to make the Makefile/configury aware of rpm's installation directories. AFAIS, upstream has hard-coded the installation paths.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Oron Peled oron@actcom.co.il changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |642160, 591389
--- Comment #8 from Oron Peled oron@actcom.co.il 2010-10-12 05:14:23 EDT --- That was quick, thanks, fixed. Details below.
SPEC URL: http://oron.fedorapeople.org/deb-package/debhelper.spec SRPM URL: http://oron.fedorapeople.org/deb-package/debhelper-8.0.0-2.fc13.src.rpm
Fixed issues: 1. BR dpkg-devel, re-added. /me should mail Debian BTS. They may have forgotten about this. ( http://packages.debian.org/source/squeeze/debhelper )
2. Made examples non-executable (with a comment in the .spec)
3. Added %check: * The failure is due to a bug in dpkg-architecture (from dpkg-devel): - Opened a Fedora bug 642160 (contains a 2 liner fix) - Marked bug 642160 as a blocker to this review - Tested with a locally fixed dpkg-architecture -- all PASS * Added perl-Test-Pod as BR, so 'make test' does not skip some tests.
3. Added another patch to Makefile so installation paths are parametric and used it in the %install phase.
Another issue: 4. Requires: po-debconf - This means Fedora bug 591389 (review request) prevent debhelper from really being installed/tested. - Marked bug 591389 as blocker to this review - More work...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Bug 591190 depends on bug 642160, which changed state.
Bug 642160 Summary: dpkg-architecture output error messages (with a fix) https://bugzilla.redhat.com/show_bug.cgi?id=642160
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #9 from Christoph Wickert cwickert@fedoraproject.org 2010-10-17 08:59:26 EDT --- '%files -f %{name}.lang' should be moved down and replace the '%files' line.
- Requires: po-debconf
- This means Fedora bug 591389 (review request) prevent debhelper from really being installed/tested.
I'm still waiting for the packages there.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #10 from Oron Peled oron@actcom.co.il 2010-10-17 18:14:11 EDT --- Fixed comment 9: - new SPEC URL: http://oron.fedorapeople.org/deb-package/debhelper.spec - new SRPM URL: http://oron.fedorapeople.org/deb-package/debhelper-8.0.0-3.fc13.src.rpm
No rush, we still wait the SRPM of po-debconf ...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Dmitrij S. Kryzhevich krege@land.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #11 from Dmitrij S. Kryzhevich krege@land.ru 2011-04-11 00:19:39 EDT --- *** Bug 457211 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Dmitrij S. Kryzhevich krege@land.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |695233(alien)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #12 from leigh scott leigh123linux@googlemail.com 2011-04-15 08:34:35 EDT --- You may want to adopt html2tex as it's currently orphaned.
http://lists.fedoraproject.org/pipermail/devel/2011-April/150167.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #13 from Oron Peled oron@actcom.co.il 2011-05-22 06:58:12 EDT --- Please note that this blocks #591192 which had its Review Request done. https://bugzilla.redhat.com/show_bug.cgi?id=591192#c13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Flag| |needinfo?(supercyper1@gmail | |.com)
--- Comment #14 from Rex Dieter rdieter@math.unl.edu 2012-01-15 13:30:08 EST --- Chen, as current reviewer, I haven't seen any feedback or comment here from you for awhile. are you still interested in helping to finish this review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #15 from Oron Peled oron@actcom.co.il 2012-01-15 17:28:35 EST --- Continuing comment 14 above, is Jeroen van Meeuwen still interested? For the record, since I want to have the debian build tools on Fedora, I'm willing to help with any related package -- this means I'll be happy to maintain/co-maintain/review (whatever helps most) this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #16 from Jeroen van Meeuwen kanarip@kanarip.com 2012-03-26 08:13:42 EDT --- New SRPM: http://hosted.kolabsys.com/~vanmeeuwen/debhelper-9.20120322-1.fc16.src.rpm New SPEC: http://hosted.kolabsys.com/~vanmeeuwen/debhelper.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com
--- Comment #17 from Miroslav Suchý msuchy@redhat.com 2012-03-27 09:33:24 EDT --- debhelper.noarch: W: incoherent-version-in-changelog 9.20120322 ['9.20120322-1.fc18', '9.20120322-1'] You are missing that release number "-1" in changelog entry.
debhelper.noarch: W: doc-file-dependency /usr/share/doc/debhelper-9.20120322/examples/rules.tiny /usr/bin/make There is make, which is automatically added to requires. As it is not used anywhere else in real code, you should filter this dependency out: http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#.25...
What happened with %check section?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
Oron Peled oron@actcom.co.il changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(supercyper1@gmail | |.com) |
--- Comment #18 from Oron Peled oron@actcom.co.il 2012-03-28 08:33:33 EDT --- Just saving Jeroen some valuable time...
New SRPM: http://oron.fedorapeople.org/deb-package/debhelper-9.20120322-2.fc15.src.rpm New SPEC: http://oron.fedorapeople.org/deb-package/debhelper.spec
* Filtered auto-requires for %_docdir * Added an %check: - Added BuildRequires: perl-Test-Harness (used by 'make test') - Also need perl-Test-More (which is not in Fedora yet) - So we run 'make test', but ignore the results
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #19 from Ralf Corsepius rc040203@freenet.de 2012-03-28 11:30:54 EDT --- (In reply to comment #18)
- Added BuildRequires: perl-Test-Harness (used by 'make test')
- Also need perl-Test-More (which is not in Fedora yet)
Both changes are wrong.
* You should not require perl-<module> but use BR: perl(<module>), instead.
* perl(Test::More) is part of Fedora for ages. BR: perl(Test::More).
- So we run 'make test', but ignore the results
Why? We should not ignore the test results.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591190
--- Comment #20 from Oron Peled oron@actcom.co.il 2012-03-28 19:15:09 EDT --- Thanks, I knew (and forgot) about the perl() thingy. What's more -- I had Test::More installed on my host, but foolishly tried: 'yum search perl-Test-More' instead of the correct: yum whatprovides 'perl(Test::More)' which shows it to belong perl-Test-Simple (Aha!)
New SRPM: http://oron.fedorapeople.org/deb-package/debhelper-9.20120322-3.fc15.src.rpm New SPEC: http://oron.fedorapeople.org/deb-package/debhelper.spec
Now all tests are good. Also added BR: perl(Test::Pod) which enables some optional tests if present.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla