Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Test-JSON - Test JSON data
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Summary: Review Request: perl-Test-JSON - Test JSON data Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: allisson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://allisson.fedorapeople.org/packages/perl-Test-JSON/perl-Test-JSON.spec
SRPM URL: http://allisson.fedorapeople.org/packages/perl-Test-JSON/perl-Test-JSON-0.06...
Description: JavaScript Object Notation (JSON) is a lightweight data interchange format. Test::JSON makes it easy to verify that you have built valid JSON and that it matches your expected output.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Miroslav Suchy msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |msuchy@redhat.com AssignedTo|nobody@fedoraproject.org |msuchy@redhat.com Flag| |fedora-review?
--- Comment #1 from Miroslav Suchy msuchy@redhat.com 2009-02-24 06:22:04 EDT --- I will look on this today.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Miroslav Suchy msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Miroslav Suchy msuchy@redhat.com 2009-02-24 07:32:46 EDT --- + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1156435 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9d8f4c2e724f67e66317f06efaa53e03 for both Test-JSON-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. not tested - package installed properly. + Macro use appears rather consistent. + Package contains code, not content. N/A no headers or static libraries. N/A no .pc file present. N/A no -devel subpackage N/A no .la files. N/A no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/00-load.........# Testing Test::JSON 0.06, Perl 5.010000, /usr/bin/perl ok t/10testjson......ok t/pod-coverage....ok t/pod.............ok All tests successful. Files=4, Tests=39, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.21 cusr 0.05 csys = 0.29 CPU) Result: PASS + Package perl-Test-JSON: Provides: perl(Test::JSON) = 0.06 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires: perl(Carp) perl(JSON::Any) perl(Test::Builder) perl(Test::Differences) perl(strict)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Allisson Azevedo allisson@gmail.com 2009-02-24 11:23:19 EDT --- New Package CVS Request ======================= Package Name: perl-Test-JSON Short Description: Test JSON data Owners: allisson Branches: F-10 F-9 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2009-02-24 15:51:00 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484202
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org