[Bug 525831] New: Review Request: vim-perl-tt2 - Syntax highlighting for the Template-Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: vim-perl-tt2 - Syntax highlighting for the Template-Toolkit Alias: vim-perl-tt2
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Summary: Review Request: vim-perl-tt2 - Syntax highlighting for the Template-Toolkit Product: Fedora Version: rawhide Platform: All URL: http://www.vim.org/scripts/script.php?script_id=830 OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2.spec SRPM URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2-0.1.3-1.fc11.src.rpm
Description: vim-perl-tt2 enables syntax highlighting for the Perl Template-Toolkit, v2.
* Contain Perl code in PERL/RAWPERL directive. (runtime sytax/perl.vim) * No folding * HTML syntax for including TT2 syntax. ( tt2html.vim / unfinished ) * Configurable START_TAG/END_TAG for your style.
*rt-0.10_01
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
--- Comment #1 from Chris Weyl cweyl@alumni.drew.edu 2009-09-26 00:16:44 EDT --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1708598
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #2 from Jussi Lehtola jussi.lehtola@iki.fi 2009-09-28 17:07:27 EDT --- You need Requires: vim-common for dir ownership.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
--- Comment #3 from Chris Weyl cweyl@alumni.drew.edu 2009-09-29 00:08:19 EDT --- We were requiring vim-perl-support (which in turn requires vim-common), but on second thought that seemed a bit.... heavy. I've replace the vim-perl-support req with vim-common.
Spec URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2.spec SRPM URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2-0.1.3-2.fc11.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1714911
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emmanuel.seyman@club-intern | |et.fr
--- Comment #4 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2009-10-04 07:16:04 EDT --- (In reply to comment #3)
Spec URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2.spec
This still contains the vim-perl-support req.
SRPM URL: http://fedorapeople.org/~cweyl/review/vim-perl-tt2-0.1.3-2.fc11.src.rpm
404
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
--- Comment #5 from Chris Weyl cweyl@alumni.drew.edu 2009-10-04 12:50:09 EDT --- Huh, weird. They're both out there now, in any case.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |emmanuel.seyman@club-intern | |et.fr Flag| |fedora-review?
--- Comment #6 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2009-10-05 16:59:14 EDT --- Let's see what this is about.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2009-10-05 19:04:52 EDT --- Review: + package builds in mock (dist-f13 i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1729479 + rpmlint issues a warning for the RPMS, is silent for the SRPM vim-perl-tt2.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + source files match upstream url 3e70d82171456550855a8b9612226c11 tt2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is not included in package. + %doc is not present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does not create any directories. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application
Looks good to me (shame about the lack of documentation, though). APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
--- Comment #8 from Chris Weyl cweyl@alumni.drew.edu 2009-10-06 00:27:01 EDT --- New Package CVS Request ======================= Package Name: vim-perl-tt2 Short Description: Syntax highlighting for the Template-Toolkit Owners: cweyl Branches: F-10 F-11 F-12 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-10-08 02:00:24 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525831
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #10 from Chris Weyl cweyl@alumni.drew.edu 2009-10-08 11:54:29 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla