[Bug 2324248] New: Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Bug ID: 2324248
           Summary: Review Request: centpkg-minimal - Used by koji to
                    download sources for building CentOS
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://tdawson.fedorapeople.org/review/centpkg-minimal/centpkg-minimal.spec
SRPM URL:
https://tdawson.fedorapeople.org/review/centpkg-minimal/centpkg-minimal-2.1....
Description: Used by koji to download sources for building CentOS
Fedora Account System Username: tdawson

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged
                URL|                            |https://git.centos.org/cent
                   |                            |os-git-common

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8223884
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

--- Comment #2 from Miro Hrončok  ---
centpkg-minimal.noarch: E: spelling-error ('koji', 'Summary(en_US) koji ->
emoji')
centpkg-minimal.noarch: E: spelling-error ('koji', '%description -l en_US koji
-> emoji')
centpkg-minimal.src: E: spelling-error ('koji', 'Summary(en_US) koji -> emoji')
centpkg-minimal.src: E: spelling-error ('koji', '%description -l en_US koji ->
emoji')

Nah, this is not emoji.

centpkg-minimal.spec:20: W: setup-not-quiet

This is a bit weird. Consider using %autosetup instead. not a blocker.

centpkg-minimal.noarch: W: no-manual-page-for-binary centpkg
centpkg-minimal.noarch: W: no-manual-page-for-binary get_sources.sh
centpkg-minimal.noarch: W: no-documentation

We know this.

centpkg-minimal.spec: W: invalid-url Source0: centpkg-minimal.tar.gz

Is this form anywhere? Or are people just downloading the old one and updating
it? Perhaps we could use
https://git.centos.org/centos-git-common/raw/28b610e9/f/get_sources.sh as a
source instead of a magical tarball from somewhere. Anyway, not a blocker
either.

---

I've installed the copr build.

$ git clone https://gitlab.com/redhat/centos-stream/rpms/python-packaging.git
$ cd python-packaging/
$ centpkg sources
++ basename /python-packaging
+ pkgname=python-packaging
+ ns_pkgname=rpms/python-packaging
+ '[' -r .git/config ']'
++ grep ' *url *= *' .git/config
++ cut -d= -f2-
++ tr -d ' '
+ url=https://gitlab.com/redhat/centos-stream/rpms/python-packaging.git
+++ dirname https://gitlab.com/redhat/centos-stream/rpms/python-packaging.git
++ basename https://gitlab.com/redhat/centos-stream/rpms
+ namespace=rpms
+ ns_pkgname=rpms/python-packaging
+ '[' -d SPECS ']'
+ '[' -s sources ']'
+ baseurl=https://sources.stream.centos.org/sources
++ head -n1 sources
++ cut '-d ' -f1
++ tr '[:upper:]' '[:lower:]'
+ hashtype=sha512
+ '[' 6 -ne 32 ']'
+ read -r _ filename _ hash
+ '[' -z '(packaging-23.2.tar.gz)' ']'
+ '[' -z
77dfeb0dc6499c55eb5bc4a5bdcdaa146122b97e8f6190c0bf75baadb4e89e4cb5b62ac7d96175acc3d8b387507472b97f0bf18c70df2b6aa78ac54e6c0eb5a3
']'
+ filename='packaging-23.2.tar.gz)'
+ tarball=packaging-23.2.tar.gz
+ curl -L -H Pragma: -o ./packaging-23.2.tar.gz -R -S --fail --retry 5
https://sources.stream.centos.org/sources/rpms/python-packaging/packaging-23...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   99k  100   99k    0     0   134k      0 --:--:-- --:--:-- --:--:--  134k
+ read -r _ filename _ hash
+ [[ -n '' ]]
+ sha512sum -c sources
packaging-23.2.tar.gz: OK

So it works as expected.

=======

# dnf install centpkg
...
Transaction failed: Rpm transaction failed.
  - file /usr/bin/centpkg from install of centpkg-0.8.13-1.fc42.noarch
conflicts with file from package centpkg-minimal-2.1.0-5.fc42.noarch

Please add:

Conflicts:      centpkg

(fedpkg-minimal conflicts with fedpkg as well.)

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Miro Hrončok  ---
I am going to sleep and don't want to block you.

Package APPROVED, assuming you add the explicit Conflicts.

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #4 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/centpkg-minimal

[Bug 2324248] Review Request: centpkg-minimal - Used by koji to download sources for building CentOS

https://bugzilla.redhat.com/show_bug.cgi?id=2324248

Troy Dawson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |CURRENTRELEASE
             Status|RELEASE_PENDING             |CLOSED
        Last Closed|                            |2024-11-08 16:16:09

--- Comment #5 from Troy Dawson  ---
centpkg-minimal is now in Fedora Rawhide.
Closing this.