[Bug 2239512] New: Review Request: rust-gix-prompt - Of the gitoxide project for handling prompts in the terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
Bug ID: 2239512 Summary: Review Request: rust-gix-prompt - Of the gitoxide project for handling prompts in the terminal Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-gix-prompt/rust-gix-prompt.spec SRPM URL: https://blinxen.fedorapeople.org/rust-gix-prompt/rust-gix-prompt-0.7.0-1.fc4...
Description: A crate of the gitoxide project for handling prompts in the terminal.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
--- Comment #1 from blinxen h-k-81@hotmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106357721
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
You are skipping *all* tests with "--skip", at that point it would be easier to flip the "check" bcond instead. Doing that would also allow you to drop the Cargo.toml patch, since dev-dependencies are only pulled in when the check bcond is enabled.
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-prompt
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-75664d66f0 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-75664d66f0
https://bugzilla.redhat.com/show_bug.cgi?id=2239512
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-09-21 19:34:44
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-75664d66f0 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com