Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: letterslaughing-fonts - Decorative/LED sans-serif font
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Summary: Review Request: letterslaughing-fonts - Decorative/LED sans-serif font Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sanjay.ankur@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://ankursinha.fedorapeople.org/letterslaughing_fonts/letterslaughing-fon...
SRPM URL: http://ankursinha.fedorapeople.org/letterslaughing_fonts/letterslaughing-fon...
Description: Letters Laughing is a decorative/LED sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |noarch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |nicolas.mailhot@laposte.net Flag| |fedora-review?, | |needinfo?(sanjay.ankur@gmai | |l.com)
--- Comment #1 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-03-22 14:50:12 EDT --- Initial review:
1. MUST: rename the package to chisholm-xxx to be consistent with "to be continued" font
2. MUST: register the font as fantasy, really, this is not a general-purpose font at all (also please use the same casing as the font files use, I don't know if fontconfig is case sensitive or not best avoid problems)
3. MUST: there is no clear version in the font files, so use the timestamp of the most recent file as version (19970902)
4. SHOULD: ask upstream to add a detached .txt licensing file to its zip (the font itself says "all rights reserved", and if the web site ever disappears we won't have any licensing grant trace anywhere)
5. SHOULD: ask usptream to use different family names for the three fonts and not invent weird styles like "at their Execution". They'll drive normal software like OpenOffice mad (yes I know this would make it a multifont package which is a bit harder to create but this is the right thing to do)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(sanjay.ankur@gmai | |l.com) |
--- Comment #2 from Ankur Sinha sanjay.ankur@gmail.com 2009-03-23 00:03:38 EDT --- hi,
The wishlist page for the font said :"Letters Laughing is a decorative/LED sans-serif font." That's why i had registered it as sans-serif..
He'll add an OFL to the zip.. As for renaming the styles, he said he couldnt do that.. Do i make this a multi spec with these families ?
Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #3 from Ankur Sinha sanjay.ankur@gmail.com 2009-03-23 04:20:59 EDT --- hi,
this is what i got for the licensing, please advise..
"As I stated in my previous email, the license is included in the font headers.
You may verify this with the following command:
grep -a -B 6 -A 84 'SIL OPEN FONT LICENSE' *.ttf
This is the standard way that the OFL is attached to fonts, and it's how my other fonts that have already been packaged for Fedora have been licensed."
regards,
Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #4 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-03-24 17:18:20 EDT --- (In reply to comment #3)
You may verify this with the following command:
grep -a -B 6 -A 84 'SIL OPEN FONT LICENSE' *.ttf
Check this and you'll see this is missing in the ttf in your package. Maybe you didn't package the same version upstream uses (and anyway a detached txt file is much better)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #5 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-03-24 17:20:30 EDT --- (In reply to comment #2)
hi,
The wishlist page for the font said :"Letters Laughing is a decorative/LED sans-serif font." That's why i had registered it as sans-serif..
The wishlist pages are not problem-free, they're only as good as the original reported made them, so as packager you need to exercise caution and check the info provided here is correct when packaging.
He'll add an OFL to the zip.. As for renaming the styles, he said he couldnt do that.. Do i make this a multi spec with these families ?
If upstream does not want to change the styles we certainly should not do it in Fedora
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #6 from Ankur Sinha sanjay.ankur@gmail.com 2009-03-25 03:59:52 EDT ---
(In reply to comment #4)
(In reply to comment #3)
You may verify this with the following command:
grep -a -B 6 -A 84 'SIL OPEN FONT LICENSE' *.ttf
Check this and you'll see this is missing in the ttf in your package. Maybe you didn't package the same version upstream uses (and anyway a detached txt file is much better)
hi,
I had used the link on the wishlist page for the package.. He directed me to another link which has "updated packages", I'll upload the packages with this new source today.
(In reply to comment #5)
okay, so i use the simple spec to or a multi spec with his styles?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #7 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-03-25 04:19:03 EDT --- If the font files do not declare different family names, only different styles, you should use the simple spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #8 from Ankur Sinha sanjay.ankur@gmail.com 2009-03-25 06:40:49 EDT --- hi,
submissions:
http://ankursinha.fedorapeople.org/letterslaughing_fonts/chisholm-letterslau...
http://ankursinha.fedorapeople.org/letterslaughing_fonts/chisholm-letterslau...
Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nicolas.mailhot@laposte.net |sanjay.ankur@gmail.com Flag|fedora-review? |fedora-review+
--- Comment #9 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-04-01 15:43:32 EDT --- This one is a go. Though I'm sure someone will report someday weird behaviours in apps du to the strange family/style names. You'll need to relay upstream then.
⑆⑆⑆ APPROVED ⑆⑆⑆
You can now continue from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a
Thank you for packaging a new Fedora font.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Ankur Sinha sanjay.ankur@gmail.com 2009-04-04 22:37:11 EDT --- New Package CVS Request ======================= Package Name: chisholm-letterslaughing-fonts Short Description: Letters Laughing is a decorative/LED sans-serif font Owners: ankursinha Branches: F-9 F-10 InitialCC: fonts-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |letterslaughing-fonts - |chisholm-letterslaughing-fo |Decorative/LED sans-serif |nts - Decorative/LED |font |sans-serif font Flag|fedora-cvs? |fedora-cvs+
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2009-04-06 23:21:46 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-04-08 03:18:13 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/chisholm-letterslaughing-fonts-200303...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-04-08 03:19:36 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/chisholm-letterslaughing-fonts-200303...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-04-09 12:10:00 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update chisholm-letterslaughing-fonts'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3452
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2009-04-09 12:13:26 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update chisholm-letterslaughing-fonts'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3465
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2009-05-06 19:25:34 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |20030323-1.fc10 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2009-05-06 19:30:58 EDT --- chisholm-letterslaughing-fonts-20030323-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491530
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|20030323-1.fc10 |20030323-1.fc9
package-review@lists.fedoraproject.org