https://bugzilla.redhat.com/show_bug.cgi?id=860515
Bug ID: 860515 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: 17 Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mate-themes - MATE Desktop themes Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: dan.mashal@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-themes.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-themes-1.4.0-1.fc17.src.... Description: MATE Desktop themes
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |840149 (MATE-DE-tracker)
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |mate-themes
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|17 |rawhide Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- moar fun to do!
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #2 from Jens Petersen petersen@redhat.com --- As a general style comment, I think it is clearer to put each BR dependency on a separate line, though this one also has a fair number of deps...
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #3 from Jens Petersen petersen@redhat.com --- For F18 and F19 can't build until mate-settings-daemon is built.
http://koji.fedoraproject.org/koji/getfile?taskID=4536295&name=root.log&...
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #4 from Dan Mashal dan.mashal@gmail.com --- Will fix asap
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |853692 | |(mate-settings-daemon)
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|853692 | |(mate-settings-daemon) |
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- naming: ok
license: ok
sources: ok 7fda787ad446c43f13baceedcbd8de50 mate-themes-1.4.0.tar.xz
1. SHOULD: include BuildArch: noarch as seems to be all architecture-independent content
2. scriptets: NOT ok MUST: add icon scriplets for each icon theme installed. for example,
%post touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ...
%postun if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ... gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : fi
%posttrans gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : ...
3. MUST fix BuildRequires. Current BuildRequires is way too much, and missing a couple items, this minimal set seems to work for me:
BuildRequires: icon-naming-utils mate-common mate-doc-utils # aka gtk2-engines-devel BuildRequires: pkgconfig(gtk-engines-2)
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #6 from Dan Mashal dan.mashal@gmail.com --- OK. Fixed per your direction.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-themes.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-themes-1.4.0-2.fc17.src.... Description: MATE Desktop themes
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #7 from Rex Dieter rdieter@math.unl.edu --- still missing a handful of icon scriptlets, but I'll leave to you to fix prior to issuing any official builds.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-cvs?
--- Comment #8 from Dan Mashal dan.mashal@gmail.com --- New Package SCM Request ======================= Package Name: mate-themes Short Description: MATE Desktop themes Owners: rdieter vicodan Branches: f16 f17 f18
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- mate-themes-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- mate-themes-1.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=860515
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mate-themes-1.4.0-3.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=860515
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-10-14 20:47:05
--- Comment #13 from Dan Mashal dan.mashal@gmail.com --- not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.
package-review@lists.fedoraproject.org