[Bug 207265] New: Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

Summary: Review Request: python-zope-interface - Zope interfaces
                    package
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-inter...
SRPM URL: http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-inter...
Description:

This is a separate distribution of the zope.interface package used in Zope 3.

It is a dependency of the Twisted 2.x stack (see Bug #171543).

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |171543
              nThis|                            |

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |208169
              nThis|                            |

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2006-10-18 17:14 EST -------
It looks like it's missing a build dep on gcc.

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2006-10-19 03:03 EST -------
Buildreqs of gcc don't need to be included; see:

http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-10-29 08:47 EST -------
* source files match upstream (can't compare MD5 since this package
  currently uses a CVS snapshot).
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
? can't check it in mock right now because my mock isn't behaving
  properly right now
* package installs properly
* rpmlint comes up empty
! %check is not present; There are some unit tests in
  zope.interface.tests
* no shared libraries, .so file is a Python C module
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* unversioned .so file is a Python C module, no -devel package necessary
* no pkgconfig files.
* no libtool .la droppings.

APPROVED, once the %check is added

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2006-10-30 15:42 EST -------
I've gotten mock fixed so I'm able to confirm that it builds in FC6/i386

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2006-10-31 12:04 EST -------
Spec URL:
http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-inter...
SRPM URL:
http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-inter...

Release 6 adds %check section; hope I got that right.

I have tested that this version builds OK in mock for FC4..rawhide (i386 and
x86_64), though I'm only intending to request builds back to FC5.

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2006-10-31 12:27 EST -------
Looks good, go ahead and import!

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-11-02 07:53 EST -------
Imported and built successfully for FC-5, FC-6, and development.
owners.list updated.

Thanks for the review.

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-02-17 11:19 EST -------
Paul: I'm interested in EL-5 branch. Would you maintain it yourself or you
won't mind if I maintained it?

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-02-17 13:26 EST -------
Package Change Request
======================
Package Name: python-zope-interface
New Branches: EL-4 EL-5

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2008-02-17 13:27 EST -------
Lubomir: I'm OK to maintain this myself but I'll happily add you as
co-maintainer for both Fedora and EPEL if you want.

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/show_bug.cgi?id=207265

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-02-18 12:18 EST -------
cvs done.

[Bug 207265] Review Request: python-zope-interface - Zope interfaces package

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-zope-interface - Zope interfaces package

https://bugzilla.redhat.com/show_bug.cgi?id=207265

------- Additional Comments From [e-mail]  2008-02-18 13:19 EST -------
Branched and built for EPEL4 and EPEL5:

38372 (python-zope-interface): Build on target fedora-4-epel succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-4-epel/38372-python-zope-inter...

38371 (python-zope-interface): Build on target fedora-5-epel succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-5-epel/38371-python-zope-inter...