[Bug 190582] New: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

Summary: Review Request: perl-Module-ScanDeps - Recursively scan
                    Perl code for dependencies
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Module-ScanDeps.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Module-ScanDeps-0.59-1.src....

Description:
An application of Module::ScanDeps is to generate executables from scripts
that contains necessary modules; this module supports two such projects,
PAR and App::Packer.  Please see their respective documentations on CPAN
for further information.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-05-06 17:31 EST -------
*** Bug 190935 has been marked as a duplicate of this bug. ***

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |190937
              nThis|                            |

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-05-07 16:28 EST -------
The source URL seems wrong (or at least I can't fetch the upstream source from
there).  I could get it from:
http://search.cpan.org/CPAN/authors/id/S/SM/SMUELLER/Module-ScanDeps-0.59.ta...
which I'll assume is the correct upstream.

The module puts an executable with a .pl extension into bindir.  I agree with
Steve that this is a bit ugly but as far as I know it's not a blocker.  (My own
denyhosts package drops denyhosts.py into bindir so I can't really complain.)

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
follows the Perl specfile template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   6e20e368ff101d8bc8f31eaa2d81c264  Module-ScanDeps-0.59.tar.gz
   6e20e368ff101d8bc8f31eaa2d81c264  Module-ScanDeps-0.59.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=20,  2 wallclock secs ( 2.38 cusr +  0.32 csys =  2.70 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED, but please double check the source URL and fix if necessary.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

------- Additional Comments From [e-mail]  2006-05-07 17:09 EST -------
(In reply to comment #2)
> The source URL seems wrong (or at least I can't fetch the upstream source from
> there).  I could get it from:
> http://search.cpan.org/CPAN/authors/id/S/SM/SMUELLER/Module-ScanDeps-0.59.ta...
> which I'll assume is the correct upstream.

I failed to catch the change of the maintainer. I will correct the URL after
importing it. Thanks.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-05-08 17:04 EST -------
Thanks for the review.

Imported and built for FC-4, FC-5, and devel.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-12-18 15:29 EST -------
Package Change Request
======================
Package Name: perl-Module-ScanDeps
New Branches: EL-4 EL-5

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

https://bugzilla.redhat.com/show_bug.cgi?id=190582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-12-18 21:12 EST -------
cvs done.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=190582

Mathieu Bridon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Mathieu Bridon  2011-01-19 04:15:54 EST ---
This package is in EPEL5, but not in EPEL6. Is there any reason for that?

I would like to see this package in EPEL6, and I am willing to help co-maintain
it.

[Bug 190582] Review Request: perl-Module-ScanDeps - Recursively scan Perl code for dependencies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=190582

--- Comment #8 from Mathieu Bridon  2011-01-19 04:41:10 EST ---
Nevermind, I just saw it's in the RHEL6 Client repository (I was only looking
at the Server one).

Sorry for the spam.