https://bugzilla.redhat.com/show_bug.cgi?id=1721564
Bug ID: 1721564 Summary: Review Request: rust-zincati - Update agent for Fedora CoreOS Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rfairley@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rfairley.fedorapeople.org/package-review/rust-zincati.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-zincati-0.0.1-1.fc31.s... Description: Update agent for Fedora CoreOS. Fedora Account System Username: rfairley
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35615242
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #1 from Robert Fairley rfairley@redhat.com --- This package will be present in Fedora 30 - most likely will need a module creating with a `rolling` branch following the latest release of the `zincati` crate.
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Don't you need to install the SystemD file too?
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #4 from Robert Fairley rfairley@redhat.com --- (In reply to Robert-André Mauchin from comment #3)
Don't you need to install the SystemD file too?
Right yes, adding this in, as well as the config files in https://github.com/coreos/zincati/tree/master/dist. Will update here.
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- In that case don't forget to add the SystemD scriptlet:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_syste...
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #6 from Robert Fairley rfairley@redhat.com --- Thanks for the review! I have updated the specfile and SRPM.
Updated specfile: https://rfairley.fedorapeople.org/package-review/rust-zincati-02/rust-zincat... Updated SRPM: https://rfairley.fedorapeople.org/package-review/rust-zincati-02/rust-zincat...
Diff of the specfile changes: https://gist.github.com/rfairley/9b46cca7c5cf00cda6560a670c3aeeaf Updated Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35633106
Also tested installation in an FCOS build - the `zincati` binary and the files are installed correctly.
rpmlint shows the following:
``` # rpmlint rust-zincati.spec rust-zincati.spec:38: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d rust-zincati.spec:39: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d/50-fedora-coreos-cincinnati.toml rust-zincati.spec:67: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d cat: 50-zincati.conf: No such file or directory 0 packages and 1 specfiles checked; 3 errors, 0 warnings. ```
However `50-zincati.conf` is installed where it should:
``` $ rpm -qf /usr/lib/sysusers.d/50-zincati.conf zincati-0.0.1-1.fc31.x86_64 ```
For the library paths, these must be under `/usr/lib/zincati/config.d` as `zincati` reads configs from there, and I didn't see a macro that enforces `/usr/lib` listed here [1], however can change it if there is one.
If this looks good, I can request an SCM repo.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros...
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #7 from Robert-André Mauchin zebob.m@gmail.com --- %{__install}, %{__mkdir_p} are not useful macros, use install and mkdir -p. As a general rule any macro starting with two underscores are for rpm private use, not public use.
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #8 from Robert Fairley rfairley@redhat.com --- (In reply to Robert-André Mauchin from comment #7)
%{__install}, %{__mkdir_p} are not useful macros, use install and mkdir -p. As a general rule any macro starting with two underscores are for rpm private use, not public use.
Thanks, will keep this in mind for next time (just saw the fedora-devel thread on this from earlier).
I updated the specfile and SRPM:
New specfile: https://rfairley.fedorapeople.org/package-review/rust-zincati-03/rust-zincat... New SRPM: https://rfairley.fedorapeople.org/package-review/rust-zincati-03/rust-zincat...
Specfile diff: https://gist.github.com/rfairley/9b46cca7c5cf00cda6560a670c3aeeaf#gistcommen... Updated Kojo scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35636349
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #10 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zincati
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #9 from Robert Fairley rfairley@redhat.com --- SCM repo request: https://pagure.io/releng/fedora-scm-requests/issue/12524
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-07-07 15:23:26
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-MODULAR-2019-74e36a7052 has been submitted as an update to Fedora 30 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-74e36a7052
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- zincati-rolling-3020190704205121.a23e773d has been pushed to the Fedora 30 Modular testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-74e36a7052
https://bugzilla.redhat.com/show_bug.cgi?id=1721564
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- zincati-rolling-3020190704205121.a23e773d has been pushed to the Fedora 30 Modular stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org