[Bug 1823117] New: Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Bug ID: 1823117 Summary: Review Request: opensurge - 2D retro platformer inspired by Sonic games Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://svgames.pl/fedora/opensurge-0.5.1.2-1.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43247079
Description: Open Surge is a fun 2D retro platformer inspired by Sonic games, and a game creation system that lets you unleash your creativity!
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1364745 (FE-GAMESIG) Doc Type|--- |No Doc Update
--- Doc Text *updated* --- If this bug requires documentation, please select an appropriate Doc Type value.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. (sagitter) anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |anto.trande@gmail.com Assignee|nobody@fedoraproject.org |anto.trande@gmail.com
--- Comment #1 from Antonio T. (sagitter) anto.trande@gmail.com --- Interesting. I will review this package soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #2 from Artur Iwicki fedora@svgames.pl --- Took a better look at the game's assets. Updated the License: tag in the -data subpackage and unbundled Roboto fonts.
spec: https://svgames.pl/fedora/opensurge-0.5.1.2-2.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43255261
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Andrea Musuruane musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan@gmail.com
--- Comment #3 from Andrea Musuruane musuruan@gmail.com --- Thanks for your effort to package opensurge. I had a go a couple of months ago.
If you could unbundle surgescript, the package would be more readable.
BR gcc is not needed (pulled in by gcc-c++).
License is GPLv3+
You can simplify building with something like: %build %cmake -DCMAKE_INSTALL_PREFIX=%{_bindir} --build build . %make_build
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #4 from Antonio T. (sagitter) anto.trande@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: opensurge-0.5.1.2-2.spec should be opensurge.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming
- Source archives provide files under multiple licenses. Please, include all licenses and comment about which files are realased under such of them.
- Why you don't package surgescript separately?
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)", "*No copyright* Creative Commons Attribution Public License (v3.0)", "*No copyright* Apache License (v2.0)", "SIL Open Font License (v1.1)", "Expat License", "*No copyright* Creative Commons CC0 Public License (v1.0)", "Apache License (v2.0)", "*No copyright* Public domain", "*No copyright* do What The Fuck you want to Public License (v2)", "GNU Lesser General Public License (v2.1 or later)", "BSD (unspecified)", "BSD 2-clause "Simplified" License". 637 files have unknown license. Detailed output of licensecheck in /home/sagitter/1823117-opensurge-0.5.1.2-2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opensurge-data [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: opensurge-0.5.1.2-2.fc33.x86_64.rpm opensurge-data-0.5.1.2-2.fc33.noarch.rpm opensurge-debuginfo-0.5.1.2-2.fc33.x86_64.rpm opensurge-debugsource-0.5.1.2-2.fc33.x86_64.rpm opensurge-0.5.1.2-2.fc33.src.rpm opensurge.x86_64: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.x86_64: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.x86_64: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.x86_64: W: no-documentation opensurge.x86_64: W: no-manual-page-for-binary opensurge opensurge-data.noarch: W: invalid-license CC-BY-3.0 opensurge-data.noarch: W: invalid-license CC-BY-SA-3.0 opensurge-data.noarch: W: invalid-license CC-0 opensurge-data.noarch: W: no-documentation opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf opensurge.src: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.src: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.src: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.src:65: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 65) 5 packages and 0 specfiles checked; 2 errors, 14 warnings.
Rpmlint (debuginfo) ------------------- Checking: opensurge-debuginfo-0.5.1.2-2.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). opensurge-debuginfo.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-debugsource.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-data.noarch: W: invalid-license CC-BY-3.0 opensurge-data.noarch: W: invalid-license CC-BY-SA-3.0 opensurge-data.noarch: W: invalid-license CC-0 opensurge-data.noarch: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-data.noarch: W: no-documentation opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf opensurge.x86_64: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.x86_64: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.x86_64: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge.x86_64: W: no-documentation opensurge.x86_64: W: no-manual-page-for-binary opensurge 4 packages and 0 specfiles checked; 1 errors, 15 warnings.
Source checksums ---------------- https://github.com/alemart/surgescript/archive/v0.5.4.3/surgescript-0.5.4.3.... : CHECKSUM(SHA256) this package : 52bb460b3a882788cc1001610d35f56a9c206b4f565db593a507f69862d6270c CHECKSUM(SHA256) upstream package : 52bb460b3a882788cc1001610d35f56a9c206b4f565db593a507f69862d6270c https://raw.githubusercontent.com/alemart/opensurge/1def8579e661e3128e495b71... : CHECKSUM(SHA256) this package : 53578904fde0199b5f32e8b036691faaa03453aea5893de61e5db5296b633268 CHECKSUM(SHA256) upstream package : 53578904fde0199b5f32e8b036691faaa03453aea5893de61e5db5296b633268 https://github.com/alemart/opensurge/archive/v0.5.1.2/opensurge-0.5.1.2.tar.... : CHECKSUM(SHA256) this package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2 CHECKSUM(SHA256) upstream package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2
Requires -------- opensurge (rpmlib, GLIBC filtered): google-roboto-fonts liballegro.so.5.2()(64bit) liballegro_acodec.so.5.2()(64bit) liballegro_audio.so.5.2()(64bit) liballegro_dialog.so.5.2()(64bit) liballegro_font.so.5.2()(64bit) liballegro_image.so.5.2()(64bit) liballegro_memfile.so.5.2()(64bit) liballegro_primitives.so.5.2()(64bit) liballegro_ttf.so.5.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) opensurge-data rtld(GNU_HASH)
opensurge-data (rpmlib, GLIBC filtered):
opensurge-debuginfo (rpmlib, GLIBC filtered):
opensurge-debugsource (rpmlib, GLIBC filtered):
Provides -------- opensurge: application() application(opensurge.desktop) bundled(surgescript) metainfo() metainfo(opensurge.appdata.xml) opensurge opensurge(x86-64)
opensurge-data: opensurge-data
opensurge-debuginfo: debuginfo(build-id) opensurge-debuginfo opensurge-debuginfo(x86-64)
opensurge-debugsource: opensurge-debugsource opensurge-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1823117 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, PHP, fonts, Java, Ocaml, Haskell, Python, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Just dropping in with some notes for improving the spec to comply with Fedora Packaging Guidelines, as I'm interested in seeing Open Surge land in Fedora. :)
# There have been some useful changes to CMakeLists.txt since v.0.5.1.2 has been released Source1: https://raw.githubusercontent.com/alemart/opensurge/1def8579e661e3128e495b71...
Why not just package a snapshot release or cherry-pick patches?
Provides: bundled(surgescript) = %{ss_version}
I'll reiterate what others have said: It'd be a much better idea to get this packaged separately and have Open Surge depend on it.
License: CC-BY-3.0 and CC-BY-SA-3.0 and CC-0 and Public Domain
The license tag is "CC-BY and CC-BY-SA and CC0 and Public Domain"
See: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
%setup -q
Use "%autosetup -p1" instead.
make %{?_smp_mflags}
Use "%make_build"
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1823344
--- Comment #6 from Artur Iwicki fedora@svgames.pl --- I didn't see much use for surgescript as a separate package, but since you insist, here it goes: https://bugzilla.redhat.com/show_bug.cgi?id=1823344
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1823344 [Bug 1823344] Review Request: surgescript - Scripting language for games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #7 from Artur Iwicki fedora@svgames.pl --- Dropping an updated spec with unbundled surgescript.
spec: https://svgames.pl/fedora/opensurge-0.5.1.2-3.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-3.src.rpm
--
Source1: CMakeLists.txt Why not just package a snapshot release or cherry-pick patches?
I'd argue that taking a file out of a snapshot kinda is a cherry-pick. ;) Either way, that was mostly needed for linking to surgescript statically, since the CMakeLists.txt from v.0.5.1.2 doesn't accommodate for that. Now that surgescript has been unbundled, I dropped this.
The license tag is "CC-BY and CC-BY-SA and CC0 and Public Domain"
Corrected that.
Use "%make_build"
Hm, pretty much every Fedora package I've seen uses "make %{?_smp_mflags}".
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. (sagitter) anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #8 from Antonio T. (sagitter) anto.trande@gmail.com --- Correct and update both SPEC and SRPM files, please. I will review your package one more time within tomorrow.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #9 from Artur Iwicki fedora@svgames.pl --- SurgeScript got accepted as a separate package, so here's a koji scratch build.
spec: https://svgames.pl/fedora/opensurge-0.5.1.2-4/opensurge.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-4/opensurge-0.5.1.2-4.fc32.src.r... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43349730
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #10 from Antonio T. (sagitter) anto.trande@gmail.com --- I guess that the font files
-- /builddir/build/BUILDROOT/opensurge-0.5.1.2-4.fc31.x86_64/usr/share/opensurge/fonts/GothicA1-Medium.ttf -- /builddir/build/BUILDROOT/opensurge-0.5.1.2-4.fc31.x86_64/usr/share/opensurge/fonts/GothicA1-Bold.ttf
should be packaged separately in a `hanyang-gothic-A1-fonts` sub-package (like happens with Pioneer: https://src.fedoraproject.org/rpms/pioneer/blob/master/f/pioneer.spec#_229) and create related symlinks inside `/usr/share/opensurge/fonts/`
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #11 from Artur Iwicki fedora@svgames.pl --- Yeah, they probably should. I never packaged fonts before, and the Font Packaging Guidelines are quite long - plus the upstream website for the font is in Korean, which I don't speak - so I went the lazy way and asked in the fonts@ mailing lists if someone would be willing to have a go at this.
https://lists.fedoraproject.org/archives/list/fonts@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Bug 1823117 depends on bug 1823344, which changed state.
Bug 1823344 Summary: Review Request: surgescript - Scripting language for games https://bugzilla.redhat.com/show_bug.cgi?id=1823344
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #12 from Antonio T. (sagitter) anto.trande@gmail.com --- Any news here?
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #13 from Artur Iwicki fedora@svgames.pl --- I have a hard time finding, for lack of better term, the source of truth for HanYang fonts. The designer's website says (it's in Korean, so I rely on auto-translation) that the font is proprietary. On the other hand, it's featured on Google Fonts and lots of different websites, tagged SIL OFL.
The designer's website states the font has 90-something weights and variants, while the freely downloadable packs only contain the typical normal/bold/italic variants, so _maybe_ it's a case of them releasing the "basic" variants for free - but I can't find any place that would confirm that.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. (sagitter) anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
--- Comment #14 from Antonio T. (sagitter) anto.trande@gmail.com --- We're stalled here. Maybe a Fe-Legal review can help us.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com Blocks|182235 (FE-Legal) |
--- Comment #15 from Tom "spot" Callaway tcallawa@redhat.com --- Hi folks. The font in question here is the Gothic A1 font family, produced by the HanYang I&C Co font foundry.
As noted, this font is listed on Google Fonts as being under the SIL Open Font License (henceforth referred to as OFL): https://fonts.google.com/specimen/Gothic+A1
When we look at the font files themselves (I looked at Google's copy), we see in the font metadata that the License is marked as:
License (English US): This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL
I happen to know the maintainer for Google Fonts and I confirmed with him that this licensing is correct, as they worked directly with the font foundry to get this font under this license. :)
Lifting FE-Legal
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #16 from Antonio T. (sagitter) anto.trande@gmail.com --- Thank you very much Tom.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #17 from Artur Iwicki fedora@svgames.pl --- Thanks, Tom.
My mind is playing tricks on me now, as I can swear I've seen something like "don't use intermediaries like Google Fonts and use upstream sources" in the Fonts Packaging policy, but I can't find it now - and looking at the git history, there newer was anything like that in the document. I'll get around to packaging the font somewhen over the weekend.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1836319
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1836319 [Bug 1836319] Review Request: hanyang-gothic-a1-fonts - Elegant Korean and Latin font family
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #18 from Artur Iwicki fedora@svgames.pl --- The HanYang Gothic A1 fonts package got approved, so here's a new build.
spec: https://svgames.pl/fedora/opensurge-0.5.1.2-5/opensurge.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-5/opensurge-0.5.1.2-5.fc32.src.r... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=45016252
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Bug 1823117 depends on bug 1836319, which changed state.
Bug 1836319 Summary: Review Request: hanyang-gothic-a1-fonts - Elegant Korean and Latin font family https://bugzilla.redhat.com/show_bug.cgi?id=1836319
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. sagitter trpost@rocketmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |trpost@rocketmail.com
--- Comment #19 from Antonio T. sagitter trpost@rocketmail.com --- I'm reviewing again.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. sagitter trpost@rocketmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #20 from Antonio T. sagitter trpost@rocketmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE-GothicA1.ttf.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)", "SIL Open Font License 1.1", "Expat License", "*No copyright* Public domain", "*No copyright* Do What The Fuck You Want To Public License, Version 2", "GNU Lesser General Public License (v2.1 or later)". 537 files have unknown license. Detailed output of licensecheck in /home/sagitter/1823117-opensurge/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opensurge-data [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: opensurge-0.5.1.2-5.fc33.x86_64.rpm opensurge-data-0.5.1.2-5.fc33.noarch.rpm opensurge-debuginfo-0.5.1.2-5.fc33.x86_64.rpm opensurge-debugsource-0.5.1.2-5.fc33.x86_64.rpm opensurge-0.5.1.2-5.fc33.src.rpm opensurge.x86_64: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.x86_64: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.x86_64: W: no-documentation opensurge.x86_64: W: no-manual-page-for-binary opensurge opensurge-data.noarch: W: no-documentation opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/GothicA1-Bold.ttf /usr/share/fonts/hanyang-gothic-a1-fonts/GothicA1-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/GothicA1-Medium.ttf /usr/share/fonts/hanyang-gothic-a1-fonts/GothicA1-Medium.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf opensurge.src: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.src: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.src: W: strange-permission opensurge.spec 600 opensurge.src:66: W: mixed-use-of-spaces-and-tabs (spaces: line 66, tab: line 63) 5 packages and 0 specfiles checked; 0 errors, 14 warnings.
Rpmlint (debuginfo) ------------------- Checking: opensurge-debuginfo-0.5.1.2-5.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/alemart/opensurge/archive/v0.5.1.2/opensurge-0.5.1.2.tar.... : CHECKSUM(SHA256) this package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2 CHECKSUM(SHA256) upstream package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2
Requires -------- opensurge (rpmlib, GLIBC filtered): font(gothica1) font(roboto) liballegro.so.5.2()(64bit) liballegro_acodec.so.5.2()(64bit) liballegro_audio.so.5.2()(64bit) liballegro_dialog.so.5.2()(64bit) liballegro_font.so.5.2()(64bit) liballegro_image.so.5.2()(64bit) liballegro_memfile.so.5.2()(64bit) liballegro_primitives.so.5.2()(64bit) liballegro_ttf.so.5.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libsurgescript.so.0.5.4.4()(64bit) opensurge-data rtld(GNU_HASH)
opensurge-data (rpmlib, GLIBC filtered):
opensurge-debuginfo (rpmlib, GLIBC filtered):
opensurge-debugsource (rpmlib, GLIBC filtered):
Provides -------- opensurge: application() application(opensurge.desktop) opensurge opensurge(x86-64)
opensurge-data: opensurge-data
opensurge-debuginfo: debuginfo(build-id) opensurge-debuginfo opensurge-debuginfo(x86-64)
opensurge-debugsource: opensurge-debugsource opensurge-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1823117 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Python, Haskell, PHP, SugarActivity, R, Perl, fonts, Java, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #21 from Artur Iwicki fedora@svgames.pl --- You'll need to reassign the ticket to yourself since the Assignee and flag:fedora-review+ user don't match.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. sagitter trpost@rocketmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|anto.trande@gmail.com |trpost@rocketmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #22 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/opensurge
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-cdfe6eabff has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-cdfe6eabff
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-8c39388753 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8c39388753
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-8c39388753 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8c39388753 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8c39388753
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-cdfe6eabff has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-cdfe6eabff *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-cdfe6eabff
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-06-15 02:06:29
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- opensurge-0.5.1.2-6.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- opensurge-0.5.1.2-6.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
stevenmark93 stevenmark68g@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stevenmark68g@gmail.com
--- Comment #29 from stevenmark93 stevenmark68g@gmail.com --- Hi, OpenSurge looks like a fun callback to classic 2D platformers, especially with that Sonic-style speed and momentum-focused level design. I like how games like this rely more on reflexes and flow rather than complex mechanics. It actually reminds me why fast-paced arcade-style games still work so well on modern platforms. Endless runners follow a similar philosophy—simple controls, quick reactions, and replay value through speed and score chasing. I’ve been reading a few breakdowns on how players enjoy that kind of gameplay loop on mobile titles too, like the ones discussed over at https://subwaysurfersapkworld.com, and it’s interesting to see how that design mindset translates across genres.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com