[Bug 2215517] New: Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Bug ID: 2215517
           Summary: Review Request: lumin - Highlight matches in files
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://sk2.org/lumin.spec
SRPM URL: https://sk2.org/lumin-1.0.0-1.fc39.src.rpm
Description: Simple command-line tool to highlight matches in files -- like
grep with --color, but shows all lines while highlighting matches.
Fedora Account System Username: skitt

This is a build-dependency for Miller (mlr).

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Stephen Kitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2024395

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2024395
[Bug 2024395] miller-6.8.0 is available

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Michel Lind  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Michel Lind  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
              Flags|fedora-review?              |
                   |needinfo?(michel@michel-slm |
                   |.name)                      |

--- Comment #2 from Michel Lind  ---
I guess this is not really needed anymore since miller 6 is rewritten? Sorry
for letting it languish so long - clearing it in case someone else needs this
package and wants to review it

needinfo canceled: [Bug 2215517] Review Request: lumin - Highlight matches in files

Product: Fedora
Version: rawhide
Component: Package Review

Michel Lind  has canceled Package Review
's request for Michel Lind
's needinfo:
Bug 2215517: Review Request: lumin - Highlight matches in files
https://bugzilla.redhat.com/show_bug.cgi?id=2215517

--- Comment #2 from Michel Lind  ---
I guess this is not really needed anymore since miller 6 is rewritten? Sorry
for letting it languish so long - clearing it in case someone else needs this
package and wants to review it

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Stephen Kitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(michel@michel-slm
                   |                            |.name)

--- Comment #3 from Stephen Kitt  ---
@[e-mail] it’s one of Miller 6’s dependencies, I packaged it in
preparation for Miller 6 way back when. (It’s vendored in the Miller 6 package,
so perhaps this is no longer useful.)

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Michel Lind  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(michel@michel-slm |fedora-review?
                   |.name)                      |
             Status|NEW                         |ASSIGNED

--- Comment #4 from Michel Lind  ---
Ah yes. And it ships CLI binaries so it is probably useful as a standalone
binary anyway. I'll try to get to it this week.

[Bug 2215517] Review Request: lumin - Highlight matches in files

https://bugzilla.redhat.com/show_bug.cgi?id=2215517

Michel Lind  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |                            |needinfo?([e-mail])

--- Comment #5 from Michel Lind  ---
Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the software is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for
Fedora
- license file is included with %license in %files
- package complies with Golang Packaging Guidelines

Package APPROVED.

===

Recommended post-import go-sig tasks (use `fedora-sig-onboard onboard $goname`:

- add @go-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @go-sig (optional)

- track package in koschei for all built branches