https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Tom "spot" Callaway <spotrh(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Tom "spot" Callaway <spotrh(a)gmail.com> ---
There are some extremely minor issues in the spec, which we can fix after
import:
1. License: tag should be "Apache-2.0"
2. When you commit the spec file to Fedora packaging git, please rename it to
"credentials-fetcher.spec"
3. One of the %description lines is longer than 80 characters (just fix it to
wrap around):
Kerberos tickets are refreshed when tickets expire or when a gMSA password
changes.
4. Summary is not capitalized, but given that the name of the project is not,
this is not an issue.
5. You may want to consider including the release value at the end of the
version string in changelog entries, like this, since you may want to update
release when version has not changed.
This is not required though.
* Mon Aug 29 2022 Tom Callaway <spotaws(a)amazon.com> - 0.0.94-1
All other rpmlint issues are safe to ignore:
credentials-fetcher-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug
credentials-fetcher-debuginfo.x86_64: E:
shared-library-without-dependency-information
/usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug
credentials-fetcher.x86_64: E: non-standard-executable-perm
/usr/sbin/credentials_fetcher_utf16_private.exe 700
credentials-fetcher.x86_64: E: non-readable
/usr/sbin/credentials_fetcher_utf16_private.exe 700
credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials-fetcherd
credentials-fetcher.x86_64: W: no-manual-page-for-binary
credentials_fetcher_utf16_private.exe
credentials-fetcher-debuginfo.x86_64: W: no-documentation
credentials-fetcher-debugsource.x86_64: W: no-documentation
credentials-fetcher.x86_64: W: name-repeated-in-summary credentials-fetcher
credentials-fetcher.src: W: name-repeated-in-summary credentials-fetcher
credentials-fetcher.x86_64: W: incoherent-version-in-changelog 0.0.94
['0.0.94-1.fc36', '0.0.94-1']
= Review =
- package meets naming guidelines
- package meets packaging guidelines
- license (Apache 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on F36 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok (the mono bits are weird, but necessary)
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122345